Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After degenerate way is removed, selectedIDs still contains removed features #3640

Closed
bhousel opened this issue Dec 9, 2016 · 1 comment
Closed

After degenerate way is removed, selectedIDs still contains removed features #3640

bhousel opened this issue Dec 9, 2016 · 1 comment
Labels
bug A bug - let's fix this!

Comments

@bhousel
Copy link
Member

bhousel commented Dec 9, 2016

Steps to reproduce:

  1. draw a line or area
  2. remove nodes with ⌘delete until the feature becomes degenerate and removes itself

What happens:

  • iD remains in Select mode rather than returning to Browse mode
    screenshot 2016-12-08 23 53 03

  • weird stuff like this empty menu:
    screenshot 2016-12-08 23 54 34

  • errors thrown on console:
    screenshot 2016-12-08 23 55 35
@bhousel bhousel added the bug A bug - let's fix this! label Dec 9, 2016
@bhousel
Copy link
Member Author

bhousel commented Dec 11, 2016

These were fixed in
a55ab03 Don't assume that all the ids in selectedIDs are valid
8a66b3d Don't enter iD.modeSelect without valid entities in selectedIDs

@bhousel bhousel closed this as completed Dec 11, 2016
@bhousel bhousel mentioned this issue Dec 22, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A bug - let's fix this!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bhousel