Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Tags editor makes value for service_times lowercase #3629

Closed
dobratzp opened this issue Dec 1, 2016 · 2 comments
Closed

All Tags editor makes value for service_times lowercase #3629

dobratzp opened this issue Dec 1, 2016 · 2 comments
Labels
usability An issue with ease-of-use or design

Comments

@dobratzp
Copy link
Contributor

dobratzp commented Dec 1, 2016

When attempting to add service_times to an object, Su gets auto-corrected to su, so when you try to enter the most common value of Su 10:00, it gets changed to su 10:00 which is incorrect as this key is supposed to follow the opening hours spec.

@bhousel
Copy link
Member

bhousel commented Dec 2, 2016

Thanks! This is like #3377
A simple fix is to get all of the 'opening_hours'-like fields to match in this regular expression here

A better fix would be to drop the regular expression entirely and consider only the values' popularities when deciding which one of several case-equivalent alternatives to present to the user.

e.g. user types 's'
"Su 10:00" has 519 uses
"su 10:00" has 4 uses

We should exclude the "su 10:00" result.

@bhousel bhousel added the usability An issue with ease-of-use or design label Dec 2, 2016
@bhousel
Copy link
Member

bhousel commented Mar 21, 2017

Closed in e1a9e7e with the simple fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usability An issue with ease-of-use or design
Projects
None yet
Development

No branches or pull requests

2 participants