data/presets: add surveillance and camera related properties #3599

bkil · 2016-11-19T11:20:19Z

https://wiki.openstreetmap.org/wiki/Tag:man_made%3Dsurveillance
https://wiki.openstreetmap.org/wiki/Proposed_features/Extended_tags_for_Key:Surveillance

These are mandatory tags:

surveillance
surveillance:type

I do not feel that the following are important, they can be selected from
the drop down manually anyway:

operator
name

These tags are well established:

camera:type has 15k users
camera:mount has 13k users
surveillance:zone has 17k users (mostly traffic is noted)
camera:direction has 6k users

These tags are in the proposed status:

contact:webcam usage is only starting
height

People used various tags instead of contact:webcam in the past
because of it being a recent tag, and/or a lack of knowledge or being
mislead by the dropdown.

Thus it is difficult to quote an exact number, but by using complex
regexp queries, I could find thousands of usages for webcam links
when properly combining man_made/surveillance/camera and various
(sometimes invalid) keywords in the key or value part of a tag:

website
image
uri, url, link, http, contact
stream
webcam

bhousel

Mostly ok, but let's:

skip the fields which are not established, or don't contain meaningful values..
remove the placeholders from fields where the placeholder can be computed..
don't default fields when we actually want the user to enter the value.. (we almost never use "default", and when you see it, it's probably a tagging oddity)

bhousel · 2016-11-21T16:47:13Z

data/presets/fields/contact/webcam.json

+    "type": "url",
+    "icon": "website",
+    "placeholder": "http://example.com/",
+    "universal": true,


This should not be a universal field

bhousel · 2016-11-21T16:52:05Z

data/presets/fields/camera/type.json

+    "key": "camera:type",
+    "type": "combo",
+    "label": "Camera type",
+    "default": "fixed",


We should not default this.. better to let users enter it..

bhousel · 2016-11-21T16:52:54Z

data/presets/fields/camera/features.json

@@ -0,0 +1,6 @@
+{
+    "key": "camera:features",


Let's not add camera:features.. it's not an established tag.

bhousel · 2016-11-21T16:53:12Z

data/presets/fields/camera/features.json

+    "key": "camera:features",
+    "type": "combo",
+    "label": "Camera features",
+    "placeholder": "Webcam, Microphone, Nightvision, Heatvision, Zoom, Motion, Wireless"


Should not suggest Uppercase placeholders for a lowercase tag

bhousel · 2016-11-21T16:53:42Z

data/presets/fields/surveillance.json

+    "key": "surveillance",
+    "type": "combo",
+    "label": "Surveillance kind",
+    "default": "outdoor",


Should not default this

bhousel · 2016-11-21T16:54:27Z

data/presets/fields/surveillance.json

+    "type": "combo",
+    "label": "Surveillance kind",
+    "default": "outdoor",
+    "placeholder": "Public, Outdoor, Indoor",


No need to add placeholder here, this will be computed automatically from available values.. Don't add Uppercase placeholders for a lowercase tag..

bhousel · 2016-11-21T16:55:57Z

data/presets/fields/surveillance/type.json

@@ -0,0 +1,8 @@
+{
+    "key": "surveillance:type",


Let's skip surveillance:type.. 98% of the values are just "camera", and the other values are noisy.

Although I default to camera as well when I map and I don't view the other variants meaningful either, however it has become kind of de facto mandatory.

For example, this visualization also requires many fields to work (described on right panel):
https://kamba4.crux.uberspace.de/

Although, I'll probably add camera:direction to the form as well because I find it easy to add in practice.

Ok, I see. Yes I have heard of Surveillance Under Surveillance. I didn't realize they were consuming this data and required surveillance:type to be filled in. In that case, what you have for this file is fine 👍

bhousel · 2016-11-21T16:56:42Z

data/presets/fields/surveillance/zone.json

+    "key": "surveillance:zone",
+    "type": "combo",
+    "label": "Zone",
+    "placeholder": "Town, Parking, Traffic, Shop, Building"


No placeholder here.. let it be computed from available values.

bkil · 2016-11-21T22:11:19Z

Thank you for the insightful comments. I will probably have some time tomorrow to do the fix-ups.

https://wiki.openstreetmap.org/wiki/Tag:man_made%3Dsurveillance https://wiki.openstreetmap.org/wiki/Proposed_features/Extended_tags_for_Key:Surveillance These are mandatory tags: * `surveillance` * `surveillance:type` I do not feel that the following are important, they can be selected from the drop down manually anyway: * `operator` * `name` These tags are well established: * `camera:type` has 15k users * `camera:mount` has 13k users * `surveillance:zone` has 17k users (mostly traffic is noted) * `camera:direction` has 6k users These tags are in the proposed status: * `contact:webcam` usage is only starting * `height` People used various tags instead of `contact:webcam` in the past because of it being a recent tag, and/or a lack of knowledge or being mislead by the dropdown. Thus it is difficult to quote an exact number, but by using complex regexp queries, I could find thousands of usages for webcam links when properly combining man_made/surveillance/camera and various (sometimes invalid) keywords in the key or value part of a tag: * `website` * `image` * `uri`, `url`, `link`, `http`, `contact` * `stream` * `webcam`

bkil · 2016-11-23T12:57:13Z

Requested changes done. Added camera:direction as well and ordered options by occurrence.

bhousel · 2016-11-26T21:52:15Z

Thanks @bkil I made a few small cleanups and merged..

BTW, you don't need to include the filename in the commit message - GitHub makes it really easy for me to see what files were changed. It's better to use those words to include a summary that I can scan quickly when I'm looking over the commits with git log.

How to Write a Git Commit Message

bhousel suggested changes Nov 21, 2016

View reviewed changes

bkil added 3 commits November 23, 2016 13:40

data/presets/presets/man_made/surveillance.json: add some common fields

c87ff32

fix up generated files via npm run build

c4140bf

bkil force-pushed the preset/surveillance_extended_fields_camera branch from 1aa2230 to c4140bf Compare November 23, 2016 12:49

bhousel merged commit c4140bf into openstreetmap:master Nov 26, 2016

bhousel mentioned this pull request Dec 22, 2016

Update to iD v2.0.2 openstreetmap/openstreetmap-website#1396

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

data/presets: add surveillance and camera related properties #3599

data/presets: add surveillance and camera related properties #3599

bkil commented Nov 19, 2016 •

edited

Loading

bhousel left a comment

bhousel Nov 21, 2016

bhousel Nov 21, 2016

bhousel Nov 21, 2016

bhousel Nov 21, 2016

bhousel Nov 21, 2016

bhousel Nov 21, 2016

bhousel Nov 21, 2016

bkil Nov 21, 2016

bhousel Nov 22, 2016

bhousel Nov 21, 2016

bkil commented Nov 21, 2016

bkil commented Nov 23, 2016

bhousel commented Nov 26, 2016

data/presets: add surveillance and camera related properties #3599

data/presets: add surveillance and camera related properties #3599

Conversation

bkil commented Nov 19, 2016 • edited Loading

bhousel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bkil commented Nov 21, 2016

bkil commented Nov 23, 2016

bhousel commented Nov 26, 2016

bkil commented Nov 19, 2016 •

edited

Loading