implement keyboard shortcuts using KeyboardEvent.key api #3572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this should improve compatibility across keyboard layouts (e.g. different languages). Old-style keycodes are still used for browsers that don't implement the new key property.
tyrasd
force-pushed
the
tyrasd-patch-keybindings
branch
from
a0051be to
5dcedd9
Compare
|
Maybe we could also use https://github.com/marijnh/w3c-keyname for this which looks to have nice fallbacks for older browsers. |
bhousel
reviewed
Jan 16, 2017
| @@ -325,7 +325,7 @@ export function uiMapInMap(context) { | |||
| redraw(); | |||
|
|
|||
| var keybinding = d3keybinding('map-in-map') | |||
| .on(key, toggle); | |||
| .on([key, '⇧'+key], toggle); | |||
There was a problem hiding this comment.
I'd rather not bind Shift-/ here, because on US keyboards that's ?, which we're saving for #1481
|
Hey @tyrasd just checking in with this.. The approach looks good, as long as it's supported in all the main browsers. While we wait for Chrome 56, is there anything else that we should do in the meantime? |
|
I tested this today in Safari 10.1 on Mac and Chrome 58 on Windows, and both seem fine. I'm going to merge it 👍 |
This was referenced Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a try on improving compatibility across different keyboard layouts (e.g. used by different language groups): Use the new KeyboardEvent.key API (if available, but most browsers already have it, only Safari seems to be a bit behind on this – for which old-style keyCodes are used as a fallback).
I've tested it on Firefox (Linux) and Chrome and IE11 (both on Windows) and there it seems to work very well. But there's a strange bug in Chrome on Linux (see this
ticketticket (which will apparently be fixed in Chrome v56+) which renders the important undo/redo and zoom shortcutsCtrl + z/ZandCtrl + +/-unusable (well, one can still use them but they are behind different keys there:Ctrl + y/YandCtrl + ß/`). Hmm…