Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preset/field additions: ssid lunch mirror outdoor_seating terms #3568

Closed

Conversation

bkil
Copy link
Contributor

@bkil bkil commented Nov 8, 2016

I could split it even further if you think it is still too big.

Support handling of some common fields:

  • internet_access:ssid
  • lunch
  • outdoor_seating

New preset:

  • highway=traffic_mirror

Extend search terms:

  • amenity=pub
  • amenity=hunting_stand
  • man_made=surveillance

@boothym
Copy link
Contributor

boothym commented Nov 11, 2016

If you adding "alpr" then you need to add "anpr" as it more commonly known: https://en.wikipedia.org/wiki/Automatic_number_plate_recognition

@bkil bkil force-pushed the presets/ssid_lunch_mirror_seating_terms branch from 87521a2 to 3fdb10b Compare November 12, 2016 08:38
@bkil bkil force-pushed the presets/ssid_lunch_mirror_seating_terms branch 2 times, most recently from 26b91cc to f146118 Compare November 12, 2016 08:45
@bkil
Copy link
Contributor Author

bkil commented Nov 12, 2016

@boothym Thanks for the suggestion, I've added some more variants and rebased to master.

@bhousel
Copy link
Member

bhousel commented Nov 18, 2016

Thanks @bkil I merged most of these just now, and added the new internet access and outdoor seating fields to a lot of related presets.

I still don't think lunch is a useful tag, so lets skip that one for now. It's a bigger lift, but I'd prefer to build a better way for people to tag opening hours.

9dfdf09 Add internet_access, outdoor_seating to presets that might use them
94a546c data/presets/presets/highway/traffic_mirror.json: new
504ed75 data/presets/presets/man_made/surveillance.json: add search terms
a0128e8 data/presets/presets/amenity/pub.json: add search terms
2b44f9e data/presets/presets/amenity/hunting_stand.json: add search terms
ed2f693 data/presets/fields/outdoor_seating.json: new (for pub, restaurant, ...)
53e2fff data/presets/fields/internet_access/ssid.json: new

@bkil
Copy link
Contributor Author

bkil commented Nov 19, 2016

I have clarified what lunch means:
https://wiki.openstreetmap.org/wiki/Key:lunch

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants