-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend presets with contact, SSID, mast, surveillance, lunch, taxon, add icons, extend .gitignore #3561
Conversation
The end goal would be that when editing an area rich in POI, most of them should have a different icon so that less point&clicking will be needed to find the right one to extend. To achieve this, all common POIs should have individual icons to serve as mnemonics, and all POIs which are usually located near each other should usually be assigned different icons.
I also liked the drop icon better, but it will be visually different from non-drinkable sources this way.
This is really too much for me to review. I'd prefer for ideas like this to be broken out into separate PRs. Just at a very quick glance:
So, I really do appreciate that you want to work on these things and I'd like to see you continue to contribute to iD, but I need your changes broken into smaller PRs, and it's really nice when things start out from an issue where we can discuss first, because I don't want you to waste your time on things I can't merge in.
No plans. I'd prefer the new namespaced ones, but I don't think they are widely used. OSM needs to come up with a plan to migrate the data before we change the fields. |
@bkil FWIW, I did just go through all your commits and cherry pick some of the changes that I think are great.. 6b77116 Add religious-christian icon to wayside_cross preset Thank you! |
Some small improvement inside data/presets
I commonly add these tags manually. All tags are accepted
and most of them are widely used.
By the way, do we have plans to help people transition from
phone
and
website
tocontact:phone
,contact:website
, etc? It would beuseful to show the old ones as well, but for newly created nodes,
the editor should definitely create these
contact:*
variants.Add icons to a few common POI
The end goal would be that when editing an area rich in POI, most of them
should have a different icon so that less point&clicking will be needed
to find the right one to extend.
To achieve this, all common POIs should have individual icons to serve as
mnemonics, and all POIs which are usually located near each other should
usually be assigned different icons.
Needed to replace the water icon with drinking-water.
I also liked the drop icon better, but it will be visually different
from non-drinkable sources this way.
.gitignore: hide automatically generated files
They are cluttering up pull requests and probably filling up the repo
as well.
Would this break anything? Could you tell me why we need them here?
Note
I didn't have time to test everything, I hope your suits can catch regressions.