Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downloading populated_places not needed anymore for the tiles #58

Closed
HolgerJeromin opened this issue Feb 17, 2016 · 2 comments
Closed

Comments

@HolgerJeromin
Copy link
Contributor

I am quite sure, that after
gravitystorm/openstreetmap-carto#1461
downloading ne_10m_populated_places.zip is not needed anymore
But it is still downloaded:

chef/roles/tile.rb

Lines 65 to 70 in 650d244

:populated_places => {
:url => "http://www.naturalearthdata.com/http//www.naturalearthdata.com/download/10m/cultural/ne_10m_populated_places.zip",
:directory => "ne_10m_populated_places",
:original => "ne_10m_populated_places.shp",
:processed => "ne_10m_populated_places_fixed.shp"
},

This change is live since a few month.
@gravitystorm can you confirm this?

@gravitystorm
Copy link
Contributor

Yes, the file is no longer needed. The processing code for it can also be removed: see

if data[:processed]
original = "#{directory}/#{data[:original]}"
processed = "#{directory}/#{data[:processed]}"
package "gdal-bin"
execute processed do
action :nothing
command "ogr2ogr #{processed} #{original}"
user "tile"
group "tile"
subscribes :run, "execute[#{file}]", :immediately
end
end

@HolgerJeromin do you fancy making a pull request for this?

@HolgerJeromin
Copy link
Contributor Author

I dont think i have time and enough knowledge for this, sorry. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants