Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate devsetup's Makefile path #48

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

4383
Copy link
Contributor

@4383 4383 commented Dec 9, 2022

Some given examples ask to execute make commands, however, this repository comes with multiple Makefile so its not clear where Makefile target are stored at first glance.

These changes propose to indicate the path to go to before executing these examples, hence, the apropriate Makefile will be at hand for users.

Some given examples ask to execute `make` commands, however, this
repository comes with multiple Makefile so its not clear where
Makefile target are stored at first glance.

These changes propose to indicate the path to go to before executing
these examples, hence, the apropriate Makefile will be at hand for users.
Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm . we planned to move the devsetup out of install_yamls into its own repo ... but so far had not time to do it :)

@stuggi stuggi merged commit 951bab6 into openstack-k8s-operators:master Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants