Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save all the Practitioner Details locally as per the user assignments #3672

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Save all the Practitioner Details locally as per the user assignments #3672

wants to merge 9 commits into from

Conversation

Rkareko
Copy link
Contributor

@Rkareko Rkareko commented Jan 9, 2025

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3659

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@Rkareko Rkareko self-assigned this Jan 9, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.9%. Comparing base (058508b) to head (3b83088).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              main   #3672   +/-   ##
=======================================
  Coverage     38.9%   38.9%           
- Complexity    1163    1166    +3     
=======================================
  Files          284     285    +1     
  Lines        15078   15088   +10     
  Branches      2671    2671           
=======================================
+ Hits          5867    5882   +15     
+ Misses        8365    8361    -4     
+ Partials       846     845    -1
Flag Coverage Δ
engine 62.6% <100.0%> (+<0.1%) ⬆️
geowidget 16.0% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...a/remote/fhir/resource/parser/CustomFhirContext.kt 100.0% <100.0%> (ø)
...core/engine/util/extension/FhirContextExtension.kt 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes

ellykits
ellykits reviewed Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@ellykits ellykits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rkareko Have you tried the newer versions of the hapi SDK library? Would it be easier to implement these changes in a fork instead of overriding the classes in FHIRCore?

@Rkareko Rkareko mentioned this pull request Jan 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellykits ellykits ellykits left review comments

@pld pld pld approved these changes

Assignees

@Rkareko Rkareko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Save all the Practitioner Details locally as per the user assignments
3 participants
@Rkareko @pld @ellykits