Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validation packs the original questionnaire response #3454

Closed
FikriMilano opened this issue Aug 19, 2024 · 1 comment · Fixed by #3455
Closed

validation packs the original questionnaire response #3454

FikriMilano opened this issue Aug 19, 2024 · 1 comment · Fixed by #3455
Assignees

Comments

@FikriMilano
Copy link
Collaborator

FikriMilano commented Aug 19, 2024

Describe the bug
When you have a repeated group inside a paginated item, then submit the form, you will save the packed version of the questionnaire response, which is wrong. Packed questionnaire response should only be used when accessing the public API of SDK. Outside of that, implementers should only use the unpacked one.

Quoted from @jingtang10 google/android-fhir#1936 (comment)

Additionally, when questionnaire response is returned to the application, repeated groups need to be unpacked again.

packed = nested items are in the answer property of the repeated group
unpacked = nested items are in the item property of the repeated group

Additional Context

@FikriMilano FikriMilano self-assigned this Aug 19, 2024
@FikriMilano FikriMilano mentioned this issue Aug 19, 2024
11 tasks
@FikriMilano FikriMilano changed the title validateQuestionnaireResponse packs the original questionnaire response Accidentally save a packed questionnaire response Aug 19, 2024
@FikriMilano FikriMilano changed the title Accidentally save a packed questionnaire response validation packs the original questionnaire response Aug 19, 2024
@FikriMilano
Copy link
Collaborator Author

@allan-on @f-odhiambo @pld

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant