Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Intel X710 Backplane and Base T #794

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

vrindle
Copy link
Contributor

@vrindle vrindle commented Jun 30, 2023

No description provided.

@openshift-ci openshift-ci bot requested review from bn222 and fepan June 30, 2023 19:42
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 30, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2023

Hi @vrindle. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrindle
Copy link
Contributor Author

vrindle commented Jun 30, 2023

@wizhaoredhat

@bn222
Copy link
Contributor

bn222 commented Jul 3, 2023

make bundle manifests introduces some changes. Let get rid of those, so that the next patch can start from a clean base.

@wizhaoredhat
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 5, 2023
@bn222
Copy link
Contributor

bn222 commented Jul 5, 2023

vrinda, don't forget to run make bundle manfests after the rebase.

@vrindle vrindle force-pushed the add_X710_cards branch 3 times, most recently from f75fd74 to 57e34b2 Compare July 6, 2023 09:55
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2023

@vrindle: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@SchSeba
Copy link
Contributor

SchSeba commented Jul 11, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SchSeba, vrindle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2023
@openshift-merge-robot openshift-merge-robot merged commit 0656e84 into openshift:master Jul 11, 2023
@wizhaoredhat
Copy link
Contributor

LGTM

SchSeba added a commit to SchSeba/sriov-network-operator that referenced this pull request Oct 30, 2024
Add a note in documentation regarding systemd mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants