-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1914066: Sync to upstream 1-26 #464
Conversation
@pliurh: This pull request references Bugzilla bug 1914066, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@pliurh: This pull request references Bugzilla bug 1914066, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@pliurh looks like some of these commits were already backported? |
I don't know why github lists those commits in this PR. Here's what I can see from my local branch.
|
I have to use cherry-pick instead of merge to get clean backport: #465 |
The problem with using cherry-pick is that the id of the commits will be changed. |
Signed-off-by: Mamduh Alassi <[email protected]>
Signed-off-by: Mamduh Alassi <[email protected]>
Signed-off-by: zshi-redhat <[email protected]>
Signed-off-by: Moshe Levi <[email protected]>
E810-CQDA2, E810-2CQDA2, E810-XXVDA2 and E810-XXVDA4 Signed-off-by: Zenghui Shi <[email protected]>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pliurh, zshi-redhat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@pliurh: All pull requests linked via external trackers have merged: Bugzilla bug 1914066 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Validate .Spec.DisableDrain
No description provided.