Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odo deploy should support creation of Knative:Service #3026

Closed
sspeiche opened this issue Apr 28, 2020 · 5 comments
Closed

odo deploy should support creation of Knative:Service #3026

sspeiche opened this issue Apr 28, 2020 · 5 comments
Labels
kind/epic An issue categorized as a high-level Epic. Needs to be scoped and broken down in 1+ stories/tasks lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@sspeiche
Copy link
Contributor

sspeiche commented Apr 28, 2020

Description

As a developer, I'd like a way to have odo deploy to utilize deployment guidance in devfile to create a kn:Service instead of a kubernetes Deployment or OpenShift Deployment config.

Acceptance criteria

  • Developer can create a new application component as a Knative Service and match the behavior in OpenShift's web ui.

Possible cli flows

Ability to use odo to deploy as a Knative Service, using deployment guidance in devfile

@sspeiche sspeiche added the kind/epic An issue categorized as a high-level Epic. Needs to be scoped and broken down in 1+ stories/tasks label Apr 28, 2020
@sspeiche sspeiche added this to the 1.3 milestone Apr 28, 2020
@kadel
Copy link
Member

kadel commented Apr 29, 2020

I think that this is something that should be captured in devfile and than odo will act on that information.
The reason why I think it would be better to captured this in devfile is to make it consistent across all tools. If I have an application that assumes that will be run as Knative Service I don't want to configure odo and again Che to make sure that my apps get deployed correctly. I would just define this in devfile, and then tools should handle it.

@sspeiche sspeiche modified the milestones: 2.0, 2.1 (planning) Jun 3, 2020
@serenamarie125 serenamarie125 changed the title Support for Knative:Service odo deploy should support creation of Knative:Service Nov 5, 2020
@serenamarie125
Copy link

Moved out to 2.2 milestone due to dependencies on devfile 2.2

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 22, 2021
@dharmit
Copy link
Member

dharmit commented Feb 23, 2021

/lifecycle frozen

@openshift-ci-robot openshift-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 23, 2021
@kadel kadel added the points/4 label Apr 6, 2021
@serenamarie125 serenamarie125 modified the milestones: 2.3 (planning), 2.4 Apr 26, 2021
@serenamarie125 serenamarie125 modified the milestones: 2.4 (planning), 2.5+ (planning) Sep 7, 2021
@kadel
Copy link
Member

kadel commented Feb 24, 2022

with odo deploy implemented and devfile having support for outer loop. It is fairly straight forward to create a devfile that utilizes KNative Service for outer loop deployment

I've created a simple example https://github.com/kadel/devfile-nodejs-deploy/blob/e42112fe1256ea2a18b93e19f6919f1c5f5513dd/devfile.yaml#L55-L69

@kadel kadel closed this as completed Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/epic An issue categorized as a high-level Epic. Needs to be scoped and broken down in 1+ stories/tasks lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

7 participants