diff --git a/pkg/vgmanager/suite_test.go b/pkg/vgmanager/suite_test.go index dcf749380..22d933f41 100644 --- a/pkg/vgmanager/suite_test.go +++ b/pkg/vgmanager/suite_test.go @@ -18,17 +18,17 @@ package vgmanager import ( "context" - "log" - "os/user" "path/filepath" "testing" "time" . "github.com/onsi/ginkgo/v2" . "github.com/onsi/gomega" - configv1 "github.com/openshift/api/config/v1" secv1 "github.com/openshift/api/security/v1" + lsblkmocks "github.com/openshift/lvm-operator/pkg/lsblk/mocks" + lvmmocks "github.com/openshift/lvm-operator/pkg/lvm/mocks" + "github.com/openshift/lvm-operator/pkg/lvmd" corev1 "k8s.io/api/core/v1" "k8s.io/client-go/kubernetes/scheme" @@ -44,10 +44,6 @@ import ( lvmv1alpha1 "github.com/openshift/lvm-operator/api/v1alpha1" "github.com/openshift/lvm-operator/pkg/filter" - lsblkmocks "github.com/openshift/lvm-operator/pkg/lsblk/mocks" - lvmmocks "github.com/openshift/lvm-operator/pkg/lvm/mocks" - "github.com/openshift/lvm-operator/pkg/lvmd" - topolvmv1 "github.com/topolvm/topolvm/api/v1" //+kubebuilder:scaffold:imports ) @@ -62,9 +58,7 @@ var ( ctx context.Context cancel context.CancelFunc testNodeSelector corev1.NodeSelector - testLVMDFile string - mockLSBLK *lsblkmocks.MockLSBLK - mockLVM *lvmmocks.MockLVM + testVGReconciler *VGReconciler ) func TestAPIs(t *testing.T) { @@ -147,20 +141,15 @@ var _ = BeforeSuite(func() { }}} Expect(k8sClient.Create(ctx, testNode)).Should(Succeed()) - testLVMD := lvmd.NewFileConfigurator(filepath.Join(GinkgoT().TempDir(), "lvmd.yaml")) - mockLSBLK = lsblkmocks.NewMockLSBLK(GinkgoT()) - mockLVM = lvmmocks.NewMockLVM(GinkgoT()) - err = (&VGReconciler{ + testVGReconciler = &VGReconciler{ Client: k8sManager.GetClient(), Scheme: k8sManager.GetScheme(), EventRecorder: k8sManager.GetEventRecorderFor(ControllerName), - LVM: mockLVM, - LSBLK: mockLSBLK, - LVMD: testLVMD, Namespace: testNamespaceName, NodeName: testNodeName, Filters: filter.DefaultFilters, - }).SetupWithManager(k8sManager) + } + err = (testVGReconciler).SetupWithManager(k8sManager) Expect(err).ToNot(HaveOccurred()) go func() { @@ -177,10 +166,30 @@ var _ = AfterSuite(func() { Expect(testEnv.Stop()).To(Succeed()) }) -func isRoot() bool { - currentUser, err := user.Current() - if err != nil { - log.Fatalf("[isRoot] Unable to get current user: %s", err) - } - return currentUser.Username == "root" || currentUser.Uid == "0" +func setupMocks() (*lvmmocks.MockLVM, *lsblkmocks.MockLSBLK) { + t := GinkgoT() + t.Helper() + + mockLSBLK := &lsblkmocks.MockLSBLK{} + mockLSBLK.Mock.Test(t) + DeferCleanup(func() { + mockLSBLK.AssertExpectations(t) + }) + mockLVM := &lvmmocks.MockLVM{} + mockLVM.Mock.Test(t) + DeferCleanup(func() { + mockLVM.AssertExpectations(t) + }) + testLVMD := lvmd.NewFileConfigurator(filepath.Join(t.TempDir(), "lvmd.yaml")) + + testVGReconciler.LSBLK = mockLSBLK + testVGReconciler.LVM = mockLVM + testVGReconciler.LVMD = testLVMD + DeferCleanup(func() { + testVGReconciler.LVMD = nil + testVGReconciler.LSBLK = nil + testVGReconciler.LVM = nil + }) + + return mockLVM, mockLSBLK } diff --git a/pkg/vgmanager/vgmanager_controller_test.go b/pkg/vgmanager/vgmanager_controller_test.go index fd30fb078..57d99ee22 100644 --- a/pkg/vgmanager/vgmanager_controller_test.go +++ b/pkg/vgmanager/vgmanager_controller_test.go @@ -5,6 +5,7 @@ import ( "fmt" "os" "path/filepath" + "runtime" . "github.com/onsi/ginkgo/v2" . "github.com/onsi/gomega" @@ -25,10 +26,8 @@ var _ = Describe("vgmanager controller", func() { }) func testMockedBlockDeviceOnHost(ctx context.Context) { - DeferCleanup(func() { - mockLVM.AssertExpectations(GinkgoT()) - mockLSBLK.AssertExpectations(GinkgoT()) - }) + By("injecting mocked LVM and LSBLK") + mockLVM, mockLSBLK := setupMocks() By("setting up the disk as a block device with losetup") device := filepath.Join(GinkgoT().TempDir(), "mock0") @@ -49,10 +48,18 @@ func testMockedBlockDeviceOnHost(ctx context.Context) { } mockLVM.EXPECT().ListVGs().Return(nil, nil).Once() + kname := device + // HACK: if we are on unix, we can simply use the "/tmp" path. + // if we are on darwin, then the symlink of the temp file + // will resolve to /private/var from /var, so we have to adjust + // the block device name + if runtime.GOOS == "darwin" { + kname = filepath.Join("/", "private", device) + } mockLSBLK.EXPECT().ListBlockDevices().Return([]lsblk.BlockDevice{ { Name: "mock0", - KName: device, + KName: kname, Type: "mocked", Model: "mocked", Vendor: "mocked",