Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InstallConfig: Add machine-pool defaults #262

Closed
wking opened this issue Sep 17, 2018 · 0 comments
Closed

InstallConfig: Add machine-pool defaults #262

wking opened this issue Sep 17, 2018 · 0 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@wking
Copy link
Member

wking commented Sep 17, 2018

Spun off from this comment, and with a positive nod from @abhinavdahiya here, we should add:

  // AWS is the default configuration used when installing on AWS for machine pools which do not define their own platform configuration.
  DefaultMachinePlatform *AWSMachinePoolPlatform `json:"defaultMachingPlatform,omitempty"`

to AWSPlatform (and similarly for LibvirtPlatform) to allow configurations to avoid repeating the same machine pool platform information twice when they want the same config for both pools.
@wking wking added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 17, 2018
@wking wking mentioned this issue Sep 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wking