Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build failure with recent version of docker/docker #116

Closed
vrothberg opened this issue Jan 8, 2019 · 8 comments
Closed

build failure with recent version of docker/docker #116

vrothberg opened this issue Jan 8, 2019 · 8 comments

Comments

@vrothberg
Copy link
Member

Vendoring recent version of docker/docker causes build failures:

vendor/github.com/openshift/imagebuilder/builder.go:16:2: cannot find package "github.com/docker/docker/builder/dockerfile/command" in any of:

It seems that the dockerfile package has been refactored into a single package (no sub-packages anymore).

@TomSweeneyRedHat
Copy link
Contributor

That might leave a mark. Sigh.

@vrothberg
Copy link
Member Author

It's really tough for our tools as other dependencies require higher versions of docker/docker, so you can imagine the haystack to untangle all the dependencies :-D

@TomSweeneyRedHat
Copy link
Contributor

I can indeed imagine, but I really don't want to do so....

@vrothberg
Copy link
Member Author

@TomSweeneyRedHat @rhatdan ... I am trying to revive the issue.

Given the strong differences between the currently vendored version and upstream, can we copy the packages in questions into imagebuilder to resolve the conflicts? I think "forking" those packages would reflect the state.

@TomSweeneyRedHat
Copy link
Contributor

I choose to hide under the table until @rhatdan weighs in....

@rhatdan
Copy link
Contributor

rhatdan commented Mar 6, 2019

I am fine with copying it.

@rhatdan
Copy link
Contributor

rhatdan commented Oct 17, 2019

@vrothberg @TomSweeneyRedHat has this been done?

@vrothberg
Copy link
Member Author

Yes, this has been done as we forked the package into https://github.com/openshift/imagebuilder/tree/master/dockerfile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants