Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace is redundant in the ConsolePlugin CR as ConsolePlugin has cluster scope #72

Open
empovit opened this issue Nov 27, 2024 · 1 comment · May be fixed by #73
Open

Namespace is redundant in the ConsolePlugin CR as ConsolePlugin has cluster scope #72

empovit opened this issue Nov 27, 2024 · 1 comment · May be fixed by #73

Comments

@empovit
Copy link

empovit commented Nov 27, 2024

As ConsolePlugin has cluster scope, namespace in charts/openshift-console-plugin/templates/consoleplugin.yaml is redundant and might be confusing:

apiVersion: console.openshift.io/v1
kind: ConsolePlugin
metadata:
  name: {{ template "openshift-console-plugin.name" . }}
  namespace: {{ .Release.Namespace }}
@spadgett spadgett linked a pull request Dec 9, 2024 that will close this issue
Open
@spadgett
Copy link
Member

spadgett commented Dec 9, 2024

Thanks for the report, @empovit! I opened a PR to remove namespace from the CR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

OCPBUGS-45901: Remove namespace from ConsolePlugin YAML spadgett/plugin-template
2 participants
@spadgett @empovit