Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNF-15494: E2E: Tuned deferred test automation #1230

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CNF-15494: E2E: Tuned deferred test automation #1230

wants to merge 1 commit into from

Conversation

SargunNarula
Copy link
Contributor

@SargunNarula SargunNarula commented Nov 28, 2024 •
edited
Loading

This PR implements functional tests for the Tuned deferred annotation feature, developed in response to the bug OCPBUGS-28647.

@openshift-ci openshift-ci bot requested review from ffromani and MarSik November 28, 2024 13:35
@SargunNarula SargunNarula changed the title E2E: WIP: Tuned deferred test automation E2E: Tuned deferred test automation Nov 29, 2024
@SargunNarula
Copy link
Contributor Author

/retest

@SargunNarula SargunNarula force-pushed the tuned_deferred branch 2 times, most recently from 02ee3e5 to db6167f Compare December 4, 2024 11:36
@SargunNarula
Copy link
Contributor Author

/retest

ffromani
ffromani reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! some comments inside about impl. details

test/e2e/performanceprofile/functests/2_performance_update/tuned_deferred.go Outdated Show resolved Hide resolved
test/e2e/performanceprofile/functests/2_performance_update/tuned_deferred.go Show resolved Hide resolved
test/e2e/performanceprofile/functests/2_performance_update/tuned_deferred.go Outdated Show resolved Hide resolved
test/e2e/performanceprofile/functests/2_performance_update/tuned_deferred.go Outdated Show resolved Hide resolved
test/e2e/performanceprofile/functests/2_performance_update/tuned_deferred.go Outdated Show resolved Hide resolved
test/e2e/performanceprofile/functests/2_performance_update/tuned_deferred.go Outdated Show resolved Hide resolved
test/e2e/performanceprofile/functests/2_performance_update/tuned_deferred.go Show resolved Hide resolved
test/e2e/performanceprofile/functests/2_performance_update/tuned_deferred.go Show resolved Hide resolved
test/e2e/performanceprofile/functests/2_performance_update/tuned_deferred.go Outdated Show resolved Hide resolved
test/e2e/performanceprofile/functests/2_performance_update/tuned_deferred.go Show resolved Hide resolved
@SargunNarula SargunNarula changed the title E2E: Tuned deferred test automation CNF-15494: E2E: Tuned deferred test automation Dec 18, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 18, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 18, 2024 •
edited by openshift-ci bot
Loading

@SargunNarula: This pull request references CNF-15494 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.18" instead.

In response to this:

This PR implements functional tests for the Tuned deferred annotation feature, developed in response to the bug OCPBUGS-28647.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ffromani
ffromani reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

good enough for now, we can (and should) iterate and improve later

test/e2e/performanceprofile/functests/2_performance_update/tuned_deferred.go Outdated Show resolved Hide resolved
test/e2e/performanceprofile/functests/2_performance_update/tuned_deferred.go Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, SargunNarula

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2024
@ffromani
Copy link
Contributor

please make the CI happy and we can merge

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c0171d3 and 2 for PR HEAD 1296e89 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 48153be and 1 for PR HEAD 1296e89 in total

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 19, 2024
@ffromani
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 61c94c4 and 2 for PR HEAD 189753a in total

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2024
@ffromani
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

@SargunNarula: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-pao-workloadhints 0c00e6f link true /test e2e-gcp-pao-workloadhints
ci/prow/e2e-gcp-pao-updating-profile 0c00e6f link true /test e2e-gcp-pao-updating-profile
ci/prow/okd-scos-e2e-aws-ovn 0c00e6f link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffromani ffromani ffromani left review comments

@mrniranjan mrniranjan mrniranjan left review comments

@MarSik MarSik Awaiting requested review from MarSik

Assignees

@ffromani ffromani

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SargunNarula @openshift-ci-robot @ffromani @mrniranjan @openshift-merge-robot