Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node tune operator failed to handle the sysctl name with dot #1128

Open
luolanzone opened this issue Aug 7, 2024 · 3 comments
Open

Node tune operator failed to handle the sysctl name with dot #1128

luolanzone opened this issue Aug 7, 2024 · 3 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@luolanzone
Copy link

Hi I checked this document and tried to update rp_filter of a sub-interface named 'antrea-ext.10' with the following manifest:

apiVersion: tuned.openshift.io/v1
kind: Tuned
metadata:
  name: antrea
  namespace: openshift-cluster-node-tuning-operator
spec:
  profile:
  - data: |
      [main]
      summary=Update Antrea VLAN interface rp_fitler
      [sysctl]
      net.ipv4.conf.antrea-ext\\.10.rp_filter=2 // net.ipv4.conf."antrea-ext.10".rp_filter=2 also failed
    name: openshift-antrea
  recommend:
  - match:
    - label: network-role
      value: egress-gateway
    priority: 30
    profile: openshift-antrea

I tried both ways with '\\' or double quote but none of them work.

2024-08-07 02:46:41,098 INFO     tuned.daemon.daemon: stopping tuning
2024-08-07 02:46:41,099 INFO     tuned.daemon.daemon: Running in automatic mode, checking what profile is recommended for your configuration.
2024-08-07 02:46:41,099 INFO     tuned.daemon.daemon: Using 'openshift-antrea' profile
2024-08-07 02:46:41,100 INFO     tuned.profiles.loader: loading profile: openshift-antrea
2024-08-07 02:46:41,100 INFO     tuned.daemon.daemon: starting tuning
2024-08-07 02:46:41,101 ERROR    tuned.utils.commands: Error when reading file '/proc/sys/net/ipv4/conf/antrea-ext\\/10/rp_filter': '[Errno 2] No such file or directory: '/proc/sys/net/ipv4/conf/antrea-ext\\\\/10/rp_filter''
2024-08-07 02:46:41,102 ERROR    tuned.plugins.plugin_sysctl: sysctl option net.ipv4.conf.antrea-ext\\.10.rp_filter will not be set, failed to read the original value.
2024-08-07 02:46:41,102 INFO     tuned.plugins.plugin_sysctl: reapplying system sysctl
2024-08-07 02:46:41,103 INFO     tuned.daemon.daemon: static tuning from profile 'openshift-antrea' applied

The version of OCP I tried is v4.16.

@luolanzone
Copy link
Author

According to sysctl man page / is also accepted:

PARAMETERS
       variable
              The name of a key to read from.  An example is kernel.ostype.  The '/' separator is also accepted in place of a '.'., 

so I all tried net/ipv4/conf/antrea-ext.10/rp_filter=2 but also failed with following errors:

2024-08-07 03:23:49,609 INFO     tuned.daemon.daemon: stopping tuning
2024-08-07 03:23:49,610 INFO     tuned.daemon.daemon: Running in automatic mode, checking what profile is recommended for your configuration.
2024-08-07 03:23:49,610 INFO     tuned.daemon.daemon: Using 'openshift-antrea' profile
2024-08-07 03:23:49,611 INFO     tuned.profiles.loader: loading profile: openshift-antrea
2024-08-07 03:23:49,611 INFO     tuned.daemon.daemon: starting tuning
2024-08-07 03:23:49,612 ERROR    tuned.utils.commands: Error when reading file '/proc/sys/net.ipv4.conf.antrea-ext/10.rp_filter': '[Errno 2] No such file or directory: '/proc/sys/net.ipv4.conf.antrea-ext/10.rp_filter''
2024-08-07 03:23:49,612 ERROR    tuned.plugins.plugin_sysctl: sysctl option net/ipv4/conf/antrea-ext.10/rp_filter will not be set, failed to read the original value.
2024-08-07 03:23:49,612 INFO     tuned.plugins.plugin_sysctl: reapplying system sysctl
2024-08-07 03:23:49,614 INFO     tuned.daemon.daemon: static tuning from profile 'openshift-antrea' applied

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 5, 2024
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

2 participants