From 68bf3c2f01aec0c8e14daa96e47365184f78f9be Mon Sep 17 00:00:00 2001 From: Vadim Rutkovsky Date: Wed, 7 Aug 2024 09:37:47 +0200 Subject: [PATCH] certrotation: remove UseSecretUpdateOnly --- .../certrotationcontroller.go | 96 ------------------- 1 file changed, 96 deletions(-) diff --git a/pkg/operator/certrotationcontroller/certrotationcontroller.go b/pkg/operator/certrotationcontroller/certrotationcontroller.go index 3bc505ac7b..a9f4fa9e87 100644 --- a/pkg/operator/certrotationcontroller/certrotationcontroller.go +++ b/pkg/operator/certrotationcontroller/certrotationcontroller.go @@ -143,10 +143,6 @@ func newCertRotationController( Lister: kubeInformersForNamespaces.InformersFor(operatorclient.OperatorNamespace).Core().V1().Secrets().Lister(), Client: kubeClient.CoreV1(), EventRecorder: eventRecorder, - - // we will remove this when we migrate all of the affected secret - // objects to their intended type: https://issues.redhat.com/browse/API-1800 - UseSecretUpdateOnly: true, }, certrotation.CABundleConfigMap{ Namespace: operatorclient.GlobalMachineSpecifiedConfigNamespace, @@ -175,10 +171,6 @@ func newCertRotationController( Lister: kubeInformersForNamespaces.InformersFor(operatorclient.TargetNamespace).Core().V1().Secrets().Lister(), Client: kubeClient.CoreV1(), EventRecorder: eventRecorder, - - // we will remove this when we migrate all of the affected secret - // objects to their intended type: https://issues.redhat.com/browse/API-1800 - UseSecretUpdateOnly: true, }, eventRecorder, &certrotation.StaticPodConditionStatusReporter{OperatorClient: operatorClient}, @@ -202,10 +194,6 @@ func newCertRotationController( Lister: kubeInformersForNamespaces.InformersFor(operatorclient.OperatorNamespace).Core().V1().Secrets().Lister(), Client: kubeClient.CoreV1(), EventRecorder: eventRecorder, - - // we will remove this when we migrate all of the affected secret - // objects to their intended type: https://issues.redhat.com/browse/API-1800 - UseSecretUpdateOnly: true, }, certrotation.CABundleConfigMap{ Namespace: operatorclient.OperatorNamespace, @@ -234,10 +222,6 @@ func newCertRotationController( Lister: kubeInformersForNamespaces.InformersFor(operatorclient.TargetNamespace).Core().V1().Secrets().Lister(), Client: kubeClient.CoreV1(), EventRecorder: eventRecorder, - - // we will remove this when we migrate all of the affected secret - // objects to their intended type: https://issues.redhat.com/browse/API-1800 - UseSecretUpdateOnly: true, }, eventRecorder, &certrotation.StaticPodConditionStatusReporter{OperatorClient: operatorClient}, @@ -263,10 +247,6 @@ func newCertRotationController( Lister: kubeInformersForNamespaces.InformersFor(operatorclient.OperatorNamespace).Core().V1().Secrets().Lister(), Client: kubeClient.CoreV1(), EventRecorder: eventRecorder, - - // we will remove this when we migrate all of the affected secret - // objects to their intended type: https://issues.redhat.com/browse/API-1800 - UseSecretUpdateOnly: true, }, certrotation.CABundleConfigMap{ Namespace: operatorclient.OperatorNamespace, @@ -295,10 +275,6 @@ func newCertRotationController( Lister: kubeInformersForNamespaces.InformersFor(operatorclient.TargetNamespace).Core().V1().Secrets().Lister(), Client: kubeClient.CoreV1(), EventRecorder: eventRecorder, - - // we will remove this when we migrate all of the affected secret - // objects to their intended type: https://issues.redhat.com/browse/API-1800 - UseSecretUpdateOnly: true, }, eventRecorder, &certrotation.StaticPodConditionStatusReporter{OperatorClient: operatorClient}, @@ -324,10 +300,6 @@ func newCertRotationController( Lister: kubeInformersForNamespaces.InformersFor(operatorclient.OperatorNamespace).Core().V1().Secrets().Lister(), Client: kubeClient.CoreV1(), EventRecorder: eventRecorder, - - // we will remove this when we migrate all of the affected secret - // objects to their intended type: https://issues.redhat.com/browse/API-1800 - UseSecretUpdateOnly: true, }, certrotation.CABundleConfigMap{ Namespace: operatorclient.OperatorNamespace, @@ -357,10 +329,6 @@ func newCertRotationController( Lister: kubeInformersForNamespaces.InformersFor(operatorclient.TargetNamespace).Core().V1().Secrets().Lister(), Client: kubeClient.CoreV1(), EventRecorder: eventRecorder, - - // we will remove this when we migrate all of the affected secret - // objects to their intended type: https://issues.redhat.com/browse/API-1800 - UseSecretUpdateOnly: true, }, eventRecorder, &certrotation.StaticPodConditionStatusReporter{OperatorClient: operatorClient}, @@ -386,10 +354,6 @@ func newCertRotationController( Lister: kubeInformersForNamespaces.InformersFor(operatorclient.OperatorNamespace).Core().V1().Secrets().Lister(), Client: kubeClient.CoreV1(), EventRecorder: eventRecorder, - - // we will remove this when we migrate all of the affected secret - // objects to their intended type: https://issues.redhat.com/browse/API-1800 - UseSecretUpdateOnly: true, }, certrotation.CABundleConfigMap{ Namespace: operatorclient.OperatorNamespace, @@ -419,10 +383,6 @@ func newCertRotationController( Lister: kubeInformersForNamespaces.InformersFor(operatorclient.TargetNamespace).Core().V1().Secrets().Lister(), Client: kubeClient.CoreV1(), EventRecorder: eventRecorder, - - // we will remove this when we migrate all of the affected secret - // objects to their intended type: https://issues.redhat.com/browse/API-1800 - UseSecretUpdateOnly: true, }, eventRecorder, &certrotation.StaticPodConditionStatusReporter{OperatorClient: operatorClient}, @@ -448,10 +408,6 @@ func newCertRotationController( Lister: kubeInformersForNamespaces.InformersFor(operatorclient.OperatorNamespace).Core().V1().Secrets().Lister(), Client: kubeClient.CoreV1(), EventRecorder: eventRecorder, - - // we will remove this when we migrate all of the affected secret - // objects to their intended type: https://issues.redhat.com/browse/API-1800 - UseSecretUpdateOnly: true, }, certrotation.CABundleConfigMap{ Namespace: operatorclient.OperatorNamespace, @@ -481,10 +437,6 @@ func newCertRotationController( Lister: kubeInformersForNamespaces.InformersFor(operatorclient.TargetNamespace).Core().V1().Secrets().Lister(), Client: kubeClient.CoreV1(), EventRecorder: eventRecorder, - - // we will remove this when we migrate all of the affected secret - // objects to their intended type: https://issues.redhat.com/browse/API-1800 - UseSecretUpdateOnly: true, }, eventRecorder, &certrotation.StaticPodConditionStatusReporter{OperatorClient: operatorClient}, @@ -509,10 +461,6 @@ func newCertRotationController( Lister: kubeInformersForNamespaces.InformersFor(operatorclient.OperatorNamespace).Core().V1().Secrets().Lister(), Client: kubeClient.CoreV1(), EventRecorder: eventRecorder, - - // we will remove this when we migrate all of the affected secret - // objects to their intended type: https://issues.redhat.com/browse/API-1800 - UseSecretUpdateOnly: true, }, certrotation.CABundleConfigMap{ Namespace: operatorclient.OperatorNamespace, @@ -544,10 +492,6 @@ func newCertRotationController( Lister: kubeInformersForNamespaces.InformersFor(operatorclient.TargetNamespace).Core().V1().Secrets().Lister(), Client: kubeClient.CoreV1(), EventRecorder: eventRecorder, - - // we will remove this when we migrate all of the affected secret - // objects to their intended type: https://issues.redhat.com/browse/API-1800 - UseSecretUpdateOnly: true, }, eventRecorder, &certrotation.StaticPodConditionStatusReporter{OperatorClient: operatorClient}, @@ -569,10 +513,6 @@ func newCertRotationController( Lister: kubeInformersForNamespaces.InformersFor(operatorclient.OperatorNamespace).Core().V1().Secrets().Lister(), Client: kubeClient.CoreV1(), EventRecorder: eventRecorder, - - // we will remove this when we migrate all of the affected secret - // objects to their intended type: https://issues.redhat.com/browse/API-1800 - UseSecretUpdateOnly: true, }, certrotation.CABundleConfigMap{ Namespace: operatorclient.OperatorNamespace, @@ -601,10 +541,6 @@ func newCertRotationController( Lister: kubeInformersForNamespaces.InformersFor(operatorclient.GlobalMachineSpecifiedConfigNamespace).Core().V1().Secrets().Lister(), Client: kubeClient.CoreV1(), EventRecorder: eventRecorder, - - // we will remove this when we migrate all of the affected secret - // objects to their intended type: https://issues.redhat.com/browse/API-1800 - UseSecretUpdateOnly: true, }, eventRecorder, &certrotation.StaticPodConditionStatusReporter{OperatorClient: operatorClient}, @@ -626,10 +562,6 @@ func newCertRotationController( Lister: kubeInformersForNamespaces.InformersFor(operatorclient.OperatorNamespace).Core().V1().Secrets().Lister(), Client: kubeClient.CoreV1(), EventRecorder: eventRecorder, - - // we will remove this when we migrate all of the affected secret - // objects to their intended type: https://issues.redhat.com/browse/API-1800 - UseSecretUpdateOnly: true, }, certrotation.CABundleConfigMap{ Namespace: operatorclient.OperatorNamespace, @@ -658,10 +590,6 @@ func newCertRotationController( Lister: kubeInformersForNamespaces.InformersFor(operatorclient.GlobalMachineSpecifiedConfigNamespace).Core().V1().Secrets().Lister(), Client: kubeClient.CoreV1(), EventRecorder: eventRecorder, - - // we will remove this when we migrate all of the affected secret - // objects to their intended type: https://issues.redhat.com/browse/API-1800 - UseSecretUpdateOnly: true, }, eventRecorder, &certrotation.StaticPodConditionStatusReporter{OperatorClient: operatorClient}, @@ -683,10 +611,6 @@ func newCertRotationController( Lister: kubeInformersForNamespaces.InformersFor(operatorclient.OperatorNamespace).Core().V1().Secrets().Lister(), Client: kubeClient.CoreV1(), EventRecorder: eventRecorder, - - // we will remove this when we migrate all of the affected secret - // objects to their intended type: https://issues.redhat.com/browse/API-1800 - UseSecretUpdateOnly: true, }, certrotation.CABundleConfigMap{ Namespace: operatorclient.OperatorNamespace, @@ -715,10 +639,6 @@ func newCertRotationController( Lister: kubeInformersForNamespaces.InformersFor(operatorclient.TargetNamespace).Core().V1().Secrets().Lister(), Client: kubeClient.CoreV1(), EventRecorder: eventRecorder, - - // we will remove this when we migrate all of the affected secret - // objects to their intended type: https://issues.redhat.com/browse/API-1800 - UseSecretUpdateOnly: true, }, eventRecorder, &certrotation.StaticPodConditionStatusReporter{OperatorClient: operatorClient}, @@ -740,10 +660,6 @@ func newCertRotationController( Lister: kubeInformersForNamespaces.InformersFor(operatorclient.OperatorNamespace).Core().V1().Secrets().Lister(), Client: kubeClient.CoreV1(), EventRecorder: eventRecorder, - - // we will remove this when we migrate all of the affected secret - // objects to their intended type: https://issues.redhat.com/browse/API-1800 - UseSecretUpdateOnly: true, }, certrotation.CABundleConfigMap{ Namespace: operatorclient.OperatorNamespace, @@ -772,10 +688,6 @@ func newCertRotationController( Lister: kubeInformersForNamespaces.InformersFor(operatorclient.TargetNamespace).Core().V1().Secrets().Lister(), Client: kubeClient.CoreV1(), EventRecorder: eventRecorder, - - // we will remove this when we migrate all of the affected secret - // objects to their intended type: https://issues.redhat.com/browse/API-1800 - UseSecretUpdateOnly: true, }, eventRecorder, &certrotation.StaticPodConditionStatusReporter{OperatorClient: operatorClient}, @@ -799,10 +711,6 @@ func newCertRotationController( Lister: kubeInformersForNamespaces.InformersFor(operatorclient.OperatorNamespace).Core().V1().Secrets().Lister(), Client: kubeClient.CoreV1(), EventRecorder: eventRecorder, - - // we will remove this when we migrate all of the affected secret - // objects to their intended type: https://issues.redhat.com/browse/API-1800 - UseSecretUpdateOnly: true, }, certrotation.CABundleConfigMap{ Namespace: operatorclient.OperatorNamespace, @@ -838,10 +746,6 @@ func newCertRotationController( Lister: kubeInformersForNamespaces.InformersFor(operatorclient.OperatorNamespace).Core().V1().Secrets().Lister(), Client: kubeClient.CoreV1(), EventRecorder: eventRecorder, - - // we will remove this when we migrate all of the affected secret - // objects to their intended type: https://issues.redhat.com/browse/API-1800 - UseSecretUpdateOnly: true, }, eventRecorder, &certrotation.StaticPodConditionStatusReporter{OperatorClient: operatorClient},