Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo.lock: update to new format #324

Closed

Conversation

steveej
Copy link
Contributor

@steveej steveej commented Oct 23, 2020

This is a syntax only update that was accomplished using
cargo generate-lockfile --offline.

This is a syntax only update that was accomplished using
`cargo generate-lockfile --offline`.
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: steveeJ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2020
@steveej
Copy link
Contributor Author

steveej commented Oct 28, 2020

I think it's easier to hold this back until we fully switch the switch to Rust 1.47.

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2020
@openshift-merge-robot
Copy link
Contributor

@steveej: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/build-only 95c558f link /test build-only

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 2, 2020
@openshift-ci-robot
Copy link

@steveej: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LalatenduMohanty
Copy link
Member

@steveej this is similar to #277, isn't it?

@steveej
Copy link
Contributor Author

steveej commented Nov 11, 2020

this is similar to #277, isn't it?

It is indeed. I'm fine closing either or both. WDYT?

@LalatenduMohanty
Copy link
Member

LalatenduMohanty commented Nov 12, 2020

It is indeed. I'm fine closing either or both. WDYT?

I am willing to update #277 . Not sure why you suggested to wait till Rust 1.47

@steveej
Copy link
Contributor Author

steveej commented Nov 12, 2020

Not sure why you suggested to wait till Rust 1.47

When I updated to that version it automatically updated the lockfile to the new format, that's what initiated the PR. I have since pinned Rust to 1.46 in the cincinnati repo locally to workaround that issue. I'm fine closing this and letting you update #277

@steveej steveej closed this Nov 12, 2020
@steveej steveej deleted the pr/cargo-lockfile-update branch November 12, 2020 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants