-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cargo.lock: update to new format #324
Conversation
This is a syntax only update that was accomplished using `cargo generate-lockfile --offline`.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: steveeJ The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I think it's easier to hold this back until we fully switch the switch to Rust 1.47. /hold |
@steveej: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@steveej: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
It is indeed. I'm fine closing either or both. WDYT? |
I am willing to update #277 . Not sure why you suggested to wait till Rust 1.47 |
When I updated to that version it automatically updated the lockfile to the new format, that's what initiated the PR. I have since pinned Rust to 1.46 in the cincinnati repo locally to workaround that issue. I'm fine closing this and letting you update #277 |
This is a syntax only update that was accomplished using
cargo generate-lockfile --offline
.