Skip to content
This repository has been archived by the owner on Jun 14, 2019. It is now read-only.

Does not remove targets when ci-operator config removes test #92

Open
chancez opened this issue Feb 25, 2019 · 2 comments
Open

Does not remove targets when ci-operator config removes test #92

chancez opened this issue Feb 25, 2019 · 2 comments

Comments

@chancez
Copy link

chancez commented Feb 25, 2019

I basically added 2 tests, verify, and unit when I first created my ci-operator config. Later I removed the verify target from the ci-operator config, and re-ran docker run -it -v $(pwd)/ci-operator:/ci-operator:z registry.svc.ci.openshift.org/ci/ci-operator-prowgen:latest --from-dir /ci-operator/config/ --to-dir /ci-operator/jobs but the prow job file didn't get updated to remove the contents relating to the verify target.

@droslean
Copy link
Member

That was intentional because prowgen checks your already existing presubmit yaml file and allow you to have the extra job that doesn't exist to the ci-operator config.

@petr-muller
Copy link
Member

I wouldn't call it "intentional", it's a side effect of the naive way how unknown jobs are handled. If we do not generate something, we just leave it as it is, even if we generated it earlier. There's room for improvement here - maybe we can annotate generated jobs?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants