Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow actions to use node16 temporarily #368

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

komish
Copy link
Contributor

@komish komish commented Jul 18, 2024

The previously implemented workaround saved us some time, but not enough. It looks like the core issue is that node20 is actually running for workflows that run are setup to use node16. In my testing, node20 exhibits the issue but node 16 and 18 do not, so I'm temporarily enabling node16 until we can get the tools installer to bump their version.

Also reverting the disabled cache.

https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Copy link
Contributor

@OchiengEd OchiengEd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

This was referenced Jul 18, 2024
@komish komish merged commit 183ff50 into openshift-helm-charts:main Jul 18, 2024
6 checks passed
@komish komish deleted the allow-node-16 branch July 18, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants