Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Python unit tests in GitHub action #362

Merged

Conversation

mgoerens
Copy link
Contributor

@mgoerens mgoerens commented Jul 2, 2024

No description provided.

This was referenced Jul 2, 2024
@komish
Copy link
Contributor

komish commented Jul 3, 2024

@mgoerens please add this file to release_info.json so that it does not get copied to other repositories. Should be similar to the change I made here https://github.com/openshift-helm-charts/development/pull/360/files#diff-b474dc8e6d039d028f37776c76a3ac558d243af475173fd9d4ca8931cd960dee. In effect, just adding the file to the mapping(s) without changing the release version should not trigger release-related workflows that also react to modifications of this file.

Once that's done, this LGTM.

This was referenced Jul 5, 2024
Copy link
Contributor

@komish komish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mgoerens mgoerens merged commit 3c094bf into openshift-helm-charts:main Jul 8, 2024
6 checks passed
@mgoerens mgoerens deleted the run_python_unit_tests branch July 8, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants