Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update script dependencies and update fn calls to match #359

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

komish
Copy link
Contributor

@komish komish commented Jun 20, 2024

Context:

I'm looking to enable dependabot for this repository soon. Before that happens, I ran dependabot in a fork and ran the E2E testing to see how it behaved. It's look all green after a couple of signature changes (captured here), so I think this should be in good shape.

Please keep an eye out for anything strange that we think may be a result of these dependency changes. Several packages iterated major versions.

Dependabot enablement will happen later, along with syft/grype.

Summary:

  • Update dependencies as dependabot would
  • Remove pytest-forked and pytest-xdist, which we aren't using (since the move to behave) and were pulling in a dependency we don't need (py).
  • Update method calls that were renamed between a package version update.

@komish komish requested review from mgoerens and jsm84 June 20, 2024 13:27
This was referenced Jun 20, 2024
Copy link
Contributor

@jsm84 jsm84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@komish LGTM...but as a side question, I suppose only semver.isvalid needed changing in our code?

@komish
Copy link
Contributor Author

komish commented Jun 21, 2024

@komish LGTM...but as a side question, I suppose only semver.isvalid needed changing in our code?

Correct. Did I change it somewhere unexpected or miss a spot?

@komish komish merged commit 5ffb91b into openshift-helm-charts:main Jun 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants