Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Support Prometheus Catalog Integ Tests for mac/windows. #982

Closed
vmmusings opened this issue Oct 27, 2022 · 2 comments
Closed

[FEATURE] Support Prometheus Catalog Integ Tests for mac/windows. #982

vmmusings opened this issue Oct 27, 2022 · 2 comments
Labels
infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. Priority-High

Comments

@vmmusings
Copy link
Member

Is your feature request related to a problem?
In the current state, prometheus integration tests work only on linux systems as we are only downloading and running the binary for linux.

What solution would you like?
Need to figure out the OS type and download the relevant prometheus binary to use.

What alternatives have you considered?
A clear and concise description of any alternative solutions or features you've considered.

Do you have any additional context?
Add any other context or screenshots about the feature request here.
@vmmusings vmmusings added enhancement New feature or request untriaged labels Oct 27, 2022
@vmmusings vmmusings mentioned this issue Oct 27, 2022
Merged
6 tasks
@dai-chen dai-chen added infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. and removed enhancement New feature or request labels Oct 28, 2022
@penghuo
Copy link
Collaborator

penghuo commented Nov 1, 2022

It is a blocker for macOS local integ test now.

@Yury-Fridlyand Yury-Fridlyand mentioned this issue Nov 1, 2022
Closed
6 tasks
@vmmusings
Copy link
Member Author

#1069
Resolved in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. Priority-High
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@penghuo @dai-chen @vmmusings