Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ExprValue so valueEnv is not required #976

Closed
joshuali925 opened this issue Oct 26, 2022 · 0 comments · Fixed by #1055
Closed

Refactor ExprValue so valueEnv is not required #976

joshuali925 opened this issue Oct 26, 2022 · 0 comments · Fixed by #1055
Labels
maintenance Improves code quality, but not the product

Comments

@joshuali925
Copy link
Member

joshuali925 commented Oct 26, 2022 •
edited
Loading

#949 (comment)

Sometimes valueEnv is not required to resolve expression, but current implementation requires valueEnv. It's better to overload as expr.valueOf() instead of expr.valueOf(null)
@joshuali925 joshuali925 added the enhancement New feature or request label Oct 26, 2022
@joshuali925 joshuali925 mentioned this issue Oct 27, 2022
Merged
6 tasks
@dai-chen dai-chen added maintenance Improves code quality, but not the product and removed enhancement New feature or request labels Oct 28, 2022
@joshuali925 joshuali925 mentioned this issue Nov 9, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance Improves code quality, but not the product
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add valueOf() to Expression joshuali925/sql
2 participants
@joshuali925 @dai-chen