Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadatalog interface and default in memory implementation #974

Conversation

penghuo
Copy link
Collaborator

@penghuo penghuo commented Oct 26, 2022

Changes

  1. Add metadatalog interface which is used by stream source, microbatch execution.
  2. Add default in memory implementation of metadatalog.

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@penghuo penghuo requested a review from a team as a code owner October 26, 2022 21:57
@penghuo penghuo added the enhancement New feature or request label Oct 26, 2022
@penghuo penghuo self-assigned this Oct 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2022

Codecov Report

Merging #974 (7c399f2) into feature/maximus-m1 (3a9d217) will decrease coverage by 3.05%.
The diff coverage is 100.00%.

@@                   Coverage Diff                    @@
##             feature/maximus-m1     #974      +/-   ##
========================================================
- Coverage                 97.95%   94.90%   -3.06%     
- Complexity                 3143     3177      +34     
========================================================
  Files                       300      317      +17     
  Lines                      7784     8556     +772     
  Branches                    500      632     +132     
========================================================
+ Hits                       7625     8120     +495     
- Misses                      158      382     +224     
- Partials                      1       54      +53     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine 97.58% <100.00%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rch/sql/executor/streaming/DefaultMetadataLog.java 100.00% <100.00%> (ø)
...rch/planner/physical/MLCommonsOperatorActions.java 1.29% <0.00%> (-0.46%) ⬇️
...rc/main/java/org/opensearch/sql/storage/Table.java 100.00% <0.00%> (ø)
...ain/java/org/opensearch/sql/analysis/Analyzer.java 100.00% <0.00%> (ø)
...n/java/org/opensearch/sql/utils/DateTimeUtils.java 100.00% <0.00%> (ø)
...java/org/opensearch/sql/ppl/parser/AstBuilder.java 100.00% <0.00%> (ø)
...ava/org/opensearch/sql/utils/SystemIndexUtils.java 100.00% <0.00%> (ø)
...opensearch/sql/planner/logical/LogicalPlanDSL.java 100.00% <0.00%> (ø)
...ensearch/sql/planner/physical/ProjectOperator.java 100.00% <0.00%> (ø)
...ch/sql/opensearch/planner/physical/ADOperator.java 0.00% <0.00%> (ø)
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@penghuo penghuo added this to the Maximus M1 - Phase 1 milestone Oct 26, 2022
Signed-off-by: Peng Huo <[email protected]>
@penghuo penghuo merged commit 63f3449 into opensearch-project:feature/maximus-m1 Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants