Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Get well plan for the Github CI pipeline #3168

Open
4 tasks
andy-k-improving opened this issue Nov 26, 2024 · 4 comments
Open
4 tasks

[FEATURE] Get well plan for the Github CI pipeline #3168

andy-k-improving opened this issue Nov 26, 2024 · 4 comments
Labels
enhancement New feature or request untriaged

Comments

@andy-k-improving
Copy link
Contributor

andy-k-improving commented Nov 26, 2024

Is your feature request related to a problem?

At the moment, the CI build for the project is broken, and PR patch being merged regardless of the CI build result.
This brings additional risk to the project, because there may be additional failure that a particular patch introduced, but being ignored by both Dev and reviewer, due to the fact that build is always failing on the main branch.

What solution would you like?
A clear and concise description of what you want to happen.
There will be three steps process on this ticket:

Phase - 1:

  • Temporarily reduce the code coverage to 94%, in order to have passing code coverage test.
  • Investigate recurrent build failures on bwc-tests, pages build and deployment / build(dynamic)

Phase - 2:

  • Update Github repo setting to only merge PR patch with a succeeded CI build, PR patch with CI failure should be rejected.

Phase -3:

  • To gradually build up the coverage back to 99% and resume the code coverage 99% check again.

What alternatives have you considered?
N/A

Do you have any additional context?
image

@andy-k-improving andy-k-improving added enhancement New feature or request untriaged labels Nov 26, 2024
@YANG-DB
Copy link
Member

YANG-DB commented Nov 27, 2024

Thanks @andy-k-improving - it sounds like we have a plan !!

@andy-k-improving
Copy link
Contributor Author

andy-k-improving commented Nov 29, 2024

Seems to be related: actions/checkout#1590, actions/checkout#1809
Tracing the commit history to better understand since when we have this on main

@andy-k-improving
Copy link
Contributor Author

andy-k-improving commented Nov 29, 2024

The error seems to happen after 8b2d01e, but I don't think it's related to the code change itself, it's more about aciton/checkout@v3 looking for an old version of node which is not exist on the ci-runner.
image

@andy-k-improving
Copy link
Contributor Author

Similar fix applied on Job-scheduler and it's working.
I will create a PR to replicate the change tomorrow.
opensearch-project/job-scheduler#702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request untriaged
Projects
None yet
Development

No branches or pull requests

2 participants