Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Day_Of_Month Function As An Alias Of DayOfMonth #1227

Conversation

GabeFernandez310
Copy link
Contributor

Description

Adds support for the day_of_month function as an alias for the dayofmonth function which currently exists in opensearch

Issues Resolved

#722

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Added Implementation And Testing For Day_Of_Month Function

Signed-off-by: GabeFernandez310 <[email protected]>
@GabeFernandez310 GabeFernandez310 requested a review from a team as a code owner January 5, 2023 19:27
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2023

Codecov Report

Merging #1227 (1f225c6) into main (6e72f18) will decrease coverage by 2.44%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1227      +/-   ##
============================================
- Coverage     98.35%   95.91%   -2.45%     
- Complexity     3601     3604       +3     
============================================
  Files           344      354      +10     
  Lines          8926     9591     +665     
  Branches        562      681     +119     
============================================
+ Hits           8779     9199     +420     
- Misses          142      334     +192     
- Partials          5       58      +53     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine 98.35% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/main/java/org/opensearch/sql/expression/DSL.java 100.00% <100.00%> (ø)
...arch/sql/expression/datetime/DateTimeFunction.java 100.00% <100.00%> (ø)
...h/sql/expression/function/BuiltinFunctionName.java 100.00% <100.00%> (ø)
...ublic/components/QueryResults/QueryResultsBody.tsx 68.32% <0.00%> (ø)
workbench/public/components/app.tsx 0.00% <0.00%> (ø)
workbench/public/components/Header/Header.tsx 100.00% <0.00%> (ø)
workbench/public/components/PPLPage/PPLPage.tsx 56.52% <0.00%> (ø)
workbench/public/components/SQLPage/SQLPage.tsx 100.00% <0.00%> (ø)
workbench/public/utils/PanelWrapper.tsx 100.00% <0.00%> (ø)
...ch/public/components/QueryResults/QueryResults.tsx 61.60% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

dai-chen
dai-chen previously approved these changes Jan 6, 2023
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

penghuo
penghuo previously approved these changes Jan 6, 2023
@GabeFernandez310 GabeFernandez310 dismissed stale reviews from penghuo and dai-chen via d992f89 January 9, 2023 23:06
@Yury-Fridlyand Yury-Fridlyand merged commit 1108379 into opensearch-project:main Jan 10, 2023
@Yury-Fridlyand Yury-Fridlyand deleted the integ-add-day_of_month-function-alt branch January 10, 2023 03:13
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 10, 2023
* Add Day_Of_Month Function As An Alias Of DayOfMonth (#194)

Signed-off-by: GabeFernandez310 <[email protected]>
(cherry picked from commit 1108379)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 10, 2023
* Add Day_Of_Month Function As An Alias Of DayOfMonth (#194)

Signed-off-by: GabeFernandez310 <[email protected]>
(cherry picked from commit 1108379)
Yury-Fridlyand pushed a commit that referenced this pull request Jan 10, 2023
* Add Day_Of_Month Function As An Alias Of DayOfMonth (#119)

Co-authored-by: GabeFernandez310 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants