Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Hour_Of_Day Function As An Alias Of Hour #1226

Merged
merged 3 commits into from
Jan 10, 2023
Merged

Add Hour_Of_Day Function As An Alias Of Hour #1226

merged 3 commits into from
Jan 10, 2023

Conversation

GabeFernandez310
Copy link
Contributor

Description

Adds support for the hour_of_day function as an alias for the hour function which currently exists in opensearch

Issues Resolved

#722

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@GabeFernandez310
Add Hour_Of_Day Function As An Alias Of Hour
f931b9a 
Added Tests And ImplementationFor Hour_Of_Day Function

Signed-off-by: GabeFernandez310 <[email protected]>
@GabeFernandez310 GabeFernandez310 requested a review from a team as a code owner January 5, 2023 19:18
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2023 •
edited
Loading

Codecov Report

Merging #1226 (0993de1) into main (dc5578a) will decrease coverage by 2.44%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1226      +/-   ##
============================================
- Coverage     98.34%   95.90%   -2.45%     
- Complexity     3594     3595       +1     
============================================
  Files           344      354      +10     
  Lines          8909     9572     +663     
  Branches        562      681     +119     
============================================
+ Hits           8762     9180     +418     
- Misses          142      334     +192     
- Partials          5       58      +53
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine 98.35% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/main/java/org/opensearch/sql/expression/DSL.java 100.00% <100.00%> (ø)
...arch/sql/expression/datetime/DateTimeFunction.java 100.00% <100.00%> (ø)
...h/sql/expression/function/BuiltinFunctionName.java 100.00% <100.00%> (ø)
workbench/public/components/SQLPage/SQLPage.tsx 100.00% <0.00%> (ø)
workbench/public/components/PPLPage/PPLPage.tsx 56.52% <0.00%> (ø)
workbench/public/components/Header/Header.tsx 100.00% <0.00%> (ø)
...h/public/components/QueryLanguageSwitch/Switch.tsx 85.71% <0.00%> (ø)
workbench/public/components/app.tsx 0.00% <0.00%> (ø)
...ublic/components/QueryResults/QueryResultsBody.tsx 68.32% <0.00%> (ø)
workbench/public/application.tsx 0.00% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Jan 5, 2023
Closed
87 tasks
@dai-chen dai-chen added the enhancement New feature or request label Jan 6, 2023
dai-chen
dai-chen previously approved these changes Jan 6, 2023
View reviewed changes
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

penghuo
penghuo previously approved these changes Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflict.

@GabeFernandez310 GabeFernandez310 dismissed stale reviews from penghuo and dai-chen via 289ea8e January 9, 2023 23:04
@GabeFernandez310
Fixed Checkstyle
0993de1 
Signed-off-by: GabeFernandez310 <[email protected]>
@penghuo
Copy link
Collaborator

penghuo commented Jan 10, 2023

BWC Test failed, let's ignore it for now.

@penghuo penghuo merged commit 9e67e5b into opensearch-project:main Jan 10, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 10, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 10, 2023
@GabeFernandez310 @github-actions
Add Hour_Of_Day Function As An Alias Of Hour (#1226)
62288c3 
* Add Hour_Of_Day Function As An Alias Of Hour

Added Tests And ImplementationFor Hour_Of_Day Function

Signed-off-by: GabeFernandez310 <[email protected]>

* Fixed Checkstyle

Signed-off-by: GabeFernandez310 <[email protected]>

Signed-off-by: GabeFernandez310 <[email protected]>
Signed-off-by: GabeFernandez310 <[email protected]>
(cherry picked from commit 9e67e5b)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 10, 2023
@GabeFernandez310 @github-actions
Add Hour_Of_Day Function As An Alias Of Hour (#1226)
d3d25e0 
* Add Hour_Of_Day Function As An Alias Of Hour

Added Tests And ImplementationFor Hour_Of_Day Function

Signed-off-by: GabeFernandez310 <[email protected]>

* Fixed Checkstyle

Signed-off-by: GabeFernandez310 <[email protected]>

Signed-off-by: GabeFernandez310 <[email protected]>
Signed-off-by: GabeFernandez310 <[email protected]>
(cherry picked from commit 9e67e5b)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 10, 2023
Merged
penghuo pushed a commit that referenced this pull request Jan 10, 2023
@opensearch-trigger-bot @GabeFernandez310
Add Hour_Of_Day Function As An Alias Of Hour (#1226) (#1269)
3e60ad3 
* Add Hour_Of_Day Function As An Alias Of Hour

Added Tests And ImplementationFor Hour_Of_Day Function

Signed-off-by: GabeFernandez310 <[email protected]>

* Fixed Checkstyle

Signed-off-by: GabeFernandez310 <[email protected]>

Signed-off-by: GabeFernandez310 <[email protected]>
Signed-off-by: GabeFernandez310 <[email protected]>
(cherry picked from commit 9e67e5b)

Co-authored-by: GabeFernandez310 <[email protected]>
penghuo pushed a commit that referenced this pull request Jan 10, 2023
@opensearch-trigger-bot @GabeFernandez310
Add Hour_Of_Day Function As An Alias Of Hour (#1226) (#1270)
f7eb026 
* Add Hour_Of_Day Function As An Alias Of Hour

Added Tests And ImplementationFor Hour_Of_Day Function

Signed-off-by: GabeFernandez310 <[email protected]>

* Fixed Checkstyle

Signed-off-by: GabeFernandez310 <[email protected]>

Signed-off-by: GabeFernandez310 <[email protected]>
Signed-off-by: GabeFernandez310 <[email protected]>
(cherry picked from commit 9e67e5b)

Co-authored-by: GabeFernandez310 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@penghuo penghuo penghuo approved these changes

@dai-chen dai-chen dai-chen left review comments

Assignees
No one assigned
Labels
backport 2.x backport 2.5 enhancement New feature or request SQL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GabeFernandez310 @codecov-commenter @penghuo @dai-chen @Yury-Fridlyand