Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Allow common keywords and scalar function name used as identifier #1212

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 2f4924a from #1191

)

* Allow score, type and scalar function name as identifier

Signed-off-by: Chen Dai <[email protected]>

* Revert score and ignore failed IT

Signed-off-by: Chen Dai <[email protected]>

* Add comparison test to address PR comment

Signed-off-by: Chen Dai <[email protected]>

Signed-off-by: Chen Dai <[email protected]>
(cherry picked from commit 2f4924a)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner January 3, 2023 17:26
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2023

Codecov Report

Merging #1212 (2f4924a) into 2.x (16606e4) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 2f4924a differs from pull request most recent head fdae569. Consider uploading reports for the commit fdae569 to get more accurate results

@@             Coverage Diff              @@
##                2.x    #1212      +/-   ##
============================================
- Coverage     98.32%   98.32%   -0.01%     
+ Complexity     3553     3548       -5     
============================================
  Files           346      344       -2     
  Lines          8761     8753       -8     
  Branches        555      554       -1     
============================================
- Hits           8614     8606       -8     
  Misses          142      142              
  Partials          5        5              
Flag Coverage Δ
sql-engine 98.32% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...expression/function/RelevanceFunctionResolver.java 100.00% <ø> (ø)
...ch/sql/planner/optimizer/LogicalPlanOptimizer.java 100.00% <ø> (ø)
...rg/opensearch/sql/analysis/ExpressionAnalyzer.java 100.00% <100.00%> (ø)
...c/main/java/org/opensearch/sql/expression/DSL.java 100.00% <100.00%> (ø)
...arch/sql/expression/datetime/DateTimeFunction.java 100.00% <100.00%> (ø)
...h/sql/expression/function/BuiltinFunctionName.java 100.00% <100.00%> (ø)
...h/sql/expression/function/OpenSearchFunctions.java 100.00% <100.00%> (ø)
...org/opensearch/sql/planner/DefaultImplementor.java 100.00% <100.00%> (ø)
...opensearch/sql/planner/logical/LogicalPlanDSL.java 100.00% <100.00%> (ø)
...ch/sql/planner/logical/LogicalPlanNodeVisitor.java 100.00% <100.00%> (ø)
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dai-chen dai-chen added bug Something isn't working SQL labels Jan 3, 2023
@dai-chen dai-chen merged commit 67f7f98 into 2.x Jan 3, 2023
@github-actions github-actions bot deleted the backport/backport-1191-to-2.x branch January 3, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working SQL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants