Add support for long value return for CEIL, CEILING and FLOOR math functions

[MitchellGale]

Add support for long value return for CEIL, CEILING and FLOOR math functions.

Ceil and ceiling should round up to the nearest whole number if there is a decimal value.
Floor should round down to the nearest whole number if there is a decimal value.

Signed-off-by: MitchellGale-BitQuill [email protected]

Description

Currently the max size returned by OpenSearchSQL for values called with ceil, ceiling, floor is INT_MAX, this PR adds additional support for some values up to LONG return value.

There are concerns regarding accepted values because of issues with floating point precision issues. Please see this comment for more detail #1036 (comment).

Issue exists in the positive domain for ceil and ceiling as well as the negative domain for floor.

Example issue ceil:

opensearchsql> select ceil(282474973688888.022);                                                                                                                                                                                                            
fetched rows / total rows = 1/1
+-----------------------------+
| ceil(282474973688888.022)   |
|-----------------------------|
| 282474973688888             |
+-----------------------------+
opensearchsql> select ceil(282474973688888.122);                                                                                                                                                                                                            
fetched rows / total rows = 1/1
+-----------------------------+
| ceil(282474973688888.122)   |
|-----------------------------|
| 282474973688889             |
+-----------------------------+

Example issue floor:

opensearchsql> select floor(-282474973688888.122);                                                                                                                                 
fetched rows / total rows = 1/1
+-------------------------------+
| floor(-282474973688888.122)   |
|-------------------------------|
| -282474973688889              |
+-------------------------------+
opensearchsql> select floor(-282474973688888.022);                                                                                                                                 
fetched rows / total rows = 1/1
+-------------------------------+
| floor(-282474973688888.022)   |
|-------------------------------|
| -282474973688888              |
+-------------------------------+

Notes

Because of the change of data type, several unit test, integration tests and comparison tests needed modification to reflect change from INT -> LONG.

Issues Resolved

#1036

Check List

• New functionality includes testing.
  • All tests pass, including unit test, integration test and doctest
• New functionality has been documented.
  • New functionality has javadoc added
  • New functionality has user manual doc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

Merging #1205 (b4b092b) into main (683d92f) will decrease coverage by 35.55%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main    #1205       +/-   ##
=============================================
- Coverage     98.32%   62.76%   -35.56%     
=============================================
  Files           344       10      -334     
  Lines          8764      658     -8106     
  Branches        554      119      -435     
=============================================
- Hits           8617      413     -8204     
- Misses          142      192       +50     
- Partials          5       53       +48     

Flag	Coverage Δ
query-workbench	62.76% <ø> (?)
sql-engine	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ssion/operator/arthmetic/MathematicalFunction.java
...arch/storage/script/filter/FilterQueryBuilder.java
...watermark/BoundedOutOfOrderWatermarkGenerator.java
...h/sql/expression/function/OpenSearchFunctions.java
...theus/data/constants/PrometheusFieldConstants.java
...java/org/opensearch/sql/expression/Expression.java
...earch/sql/planner/physical/collector/Rounding.java
...ensearch/sql/expression/function/FunctionName.java
...ensearch/sql/expression/ExpressionNodeVisitor.java
...rc/main/java/org/opensearch/sql/storage/Table.java
... and 344 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[penghuo]

if the function of ceil and ceiling is same, we can do similar thing like mysql doc https://dev.mysql.com/doc/refman/5.6/en/mathematical-functions.html#function_ceiling

[Yury-Fridlyand]

Rebased and updated in b4b092b.

[dai-chen]

Thanks for the changes!