Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix arithmetic operator precedence #1188

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport ab46fdd from #1172

* Fix precedence by reordering grammar rule

Signed-off-by: Chen Dai <[email protected]>

* Fix precedence in PPL

Signed-off-by: Chen Dai <[email protected]>

Signed-off-by: Chen Dai <[email protected]>
(cherry picked from commit ab46fdd)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner December 16, 2022 17:38
@dai-chen dai-chen self-assigned this Dec 16, 2022
@dai-chen dai-chen added the bug Something isn't working label Dec 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2022

Codecov Report

Merging #1188 (ab46fdd) into 2.x (6c0af83) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head ab46fdd differs from pull request most recent head 61977ea. Consider uploading reports for the commit 61977ea to get more accurate results

@@             Coverage Diff              @@
##                2.x    #1188      +/-   ##
============================================
- Coverage     98.31%   98.31%   -0.01%     
+ Complexity     3541     3521      -20     
============================================
  Files           346      342       -4     
  Lines          8739     8699      -40     
  Branches        555      554       -1     
============================================
- Hits           8592     8552      -40     
  Misses          142      142              
  Partials          5        5              
Flag Coverage Δ
sql-engine 98.31% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pensearch/sql/ppl/parser/AstExpressionBuilder.java 100.00% <100.00%> (ø)
...pensearch/sql/sql/parser/AstExpressionBuilder.java 100.00% <100.00%> (ø)
...rc/main/java/org/opensearch/sql/storage/Table.java 100.00% <0.00%> (ø)
...org/opensearch/sql/planner/DefaultImplementor.java 100.00% <0.00%> (ø)
...rg/opensearch/sql/analysis/ExpressionAnalyzer.java 100.00% <0.00%> (ø)
...opensearch/sql/planner/logical/LogicalPlanDSL.java 100.00% <0.00%> (ø)
...search/sql/planner/optimizer/pattern/Patterns.java 100.00% <0.00%> (ø)
...ch/sql/planner/logical/LogicalPlanNodeVisitor.java 100.00% <0.00%> (ø)
...ch/sql/planner/optimizer/LogicalPlanOptimizer.java 100.00% <0.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dai-chen dai-chen merged commit 7edc72e into 2.x Dec 16, 2022
@github-actions github-actions bot deleted the backport/backport-1172-to-2.x branch December 16, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants