Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jackson to 2.14.1 and fix dependency resolution issues #1150

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

reta
Copy link
Contributor

@reta reta commented Dec 8, 2022

Signed-off-by: Andriy Redko [email protected]

Description

The distribution builds [1] are failing with:

Execution failed for task ':opensearch-sql-plugin:compileJava'.
> Could not resolve all dependencies for configuration ':opensearch-sql-plugin:compileClasspath'.
   > Conflict(s) found for the following module(s):
       - com.fasterxml.jackson.dataformat:jackson-dataformat-smile between versions 2.14.1 and 2.13.4
       - com.fasterxml.jackson.dataformat:jackson-dataformat-yaml between versions 2.14.1 and 2.13.4
     Run with:
         --scan or
         :opensearch-sql-plugin:dependencyInsight --configuration compileClasspath --dependency com.fasterxml.jackson.dataformat:jackson-dataformat-smile
     to get more insight on how to solve the conflict.

[1] https://build.ci.opensearch.org/job/distribution-build-opensearch/6673/console

Issues Resolved

Closes #1148

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta reta requested a review from a team as a code owner December 8, 2022 18:20
@dai-chen dai-chen added the dependencies Pull requests that update a dependency file label Dec 8, 2022
@reta
Copy link
Contributor Author

reta commented Dec 8, 2022

Ah ... missed integ_test module, it also forces resolution ....

@codecov-commenter
Copy link

Codecov Report

Merging #1150 (bd499a3) into 2.x (2af7321) will decrease coverage by 2.50%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x    #1150      +/-   ##
============================================
- Coverage     98.30%   95.80%   -2.51%     
  Complexity     3518     3518              
============================================
  Files           342      352      +10     
  Lines          8694     9352     +658     
  Branches        554      673     +119     
============================================
+ Hits           8547     8960     +413     
- Misses          142      334     +192     
- Partials          5       58      +53     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine 98.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
workbench/public/components/PPLPage/PPLPage.tsx 56.52% <0.00%> (ø)
workbench/public/utils/PanelWrapper.tsx 100.00% <0.00%> (ø)
workbench/public/components/SQLPage/SQLPage.tsx 100.00% <0.00%> (ø)
...ch/public/components/QueryResults/QueryResults.tsx 61.60% <0.00%> (ø)
workbench/public/components/Main/main.tsx 53.00% <0.00%> (ø)
workbench/public/components/Header/Header.tsx 100.00% <0.00%> (ø)
workbench/public/application.tsx 0.00% <0.00%> (ø)
...ublic/components/QueryResults/QueryResultsBody.tsx 68.32% <0.00%> (ø)
workbench/public/components/app.tsx 0.00% <0.00%> (ø)
...h/public/components/QueryLanguageSwitch/Switch.tsx 85.71% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@penghuo penghuo merged commit c5e8fc0 into opensearch-project:2.x Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] OS distribution 2.3.1 failed to build on SQL
6 participants