Add Week_Of_Year Function To OpenSearch #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yury-Fridlyand
previously approved these changes
Dec 1, 2022
dai-chen
previously approved these changes
Dec 5, 2022
Signed-off-by: GabeFernandez310 <[email protected]>
Signed-off-by: GabeFernandez310 <[email protected]>
GabeFernandez310
dismissed stale reviews from dai-chen and Yury-Fridlyand
via
76f8d38
GabeFernandez310
force-pushed
the
integ-add-week_of_year-function
branch
from
da586fe to
76f8d38
Compare
GabeFernandez310
requested review from
Yury-Fridlyand and
dai-chen
and removed request for
penghuo,
Yury-Fridlyand and
dai-chen
dai-chen
approved these changes
Dec 5, 2022
penghuo
approved these changes
Dec 6, 2022
penghuo
approved these changes
Dec 6, 2022
87 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the
week_of_yearfunction to the SQL plugin. It behaves like theweekfunction which already exists in the new engine, and both are aligned with MySQL*Note: This function does not currently support the
TIMEtype because adding support for this is currently blocked by PR 1047. This will be accomplished in future work.Issues Resolved
#722
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.