-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue in HashingStoredFieldVisitor with stored fields #4826
Merged
willyborankin
merged 5 commits into
opensearch-project:main
from
cwperks:fix-stored-fields
Oct 21, 2024
Merged
Fix issue in HashingStoredFieldVisitor with stored fields #4826
willyborankin
merged 5 commits into
opensearch-project:main
from
cwperks:fix-stored-fields
Oct 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
DarshitChanpura,
derek-ho,
nibix,
peternied,
RyanL1997,
reta and
willyborankin
as code owners
October 21, 2024 14:49
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4826 +/- ##
==========================================
- Coverage 70.99% 70.89% -0.10%
==========================================
Files 310 310
Lines 20938 20946 +8
Branches 3326 3331 +5
==========================================
- Hits 14865 14850 -15
- Misses 4325 4344 +19
- Partials 1748 1752 +4
|
Signed-off-by: Craig Perkins <[email protected]>
nibix
approved these changes
Oct 21, 2024
willyborankin
approved these changes
Oct 21, 2024
willyborankin
merged commit Oct 21, 2024
8d7259d
into
opensearch-project:main
41 of 43 checks passed
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 21, 2024
Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 8d7259d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
nibix
added a commit
to nibix/security
that referenced
this pull request
Oct 21, 2024
Signed-off-by: Nils Bandener <[email protected]>
nibix
added a commit
to nibix/security
that referenced
this pull request
Nov 6, 2024
Signed-off-by: Nils Bandener <[email protected]>
nibix
added a commit
to nibix/security
that referenced
this pull request
Nov 13, 2024
Signed-off-by: Nils Bandener <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug inside HashingStoredFieldVisitor to account for stored_fields which are stored separately from
_source
in the backing index. This PR also adds integ tests to verify the correct behavior.Bug fix
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.