Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport integration tests to 2.x #3188

Closed
cwperks opened this issue Aug 15, 2023 · 2 comments
Closed

Backport integration tests to 2.x #3188

cwperks opened this issue Aug 15, 2023 · 2 comments
Labels
bug Something isn't working triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.

Comments

@cwperks
Copy link
Member

cwperks commented Aug 15, 2023

Stemming from discussion on #3182, the codeql check is failing with:

Task :compileIntegrationTestJava FAILED

https://github.com/opensearch-project/security/actions/runs/5870600207/job/15918932614?pr=3182

The integrationTest framework was introduced in a series of PRs into main and was intentionally not backported to 2.x[link to discussion]. No support for the integrationTest package exists on 2.x and no gradle task related to the integrationTest package should works on 2.x. We should backport these changes.

Task: Backport changes associated with the linked PR.

@cwperks cwperks added bug Something isn't working untriaged Require the attention of the repository maintainers and may need to be prioritized labels Aug 15, 2023
@stephen-crawford stephen-crawford changed the title Disable compileIntegrationTestJava from running during codeql check on 2.x Backport integration tests to 2.x Aug 21, 2023
@stephen-crawford stephen-crawford added triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Aug 21, 2023
@stephen-crawford
Copy link
Contributor

[Triage] Hi @cwperks, thank you for pointing this out. For the time being, it seems like the actionable task is going to be adding the integration tests to the 2.x line.

@cwperks
Copy link
Member Author

cwperks commented Aug 29, 2023

Closing this issue as a duplicate. #3230 has more details on which PRs need to be backported.

@cwperks cwperks closed this as completed Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.
Projects
None yet
Development

No branches or pull requests

2 participants