Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] There should be a way for a local developer to know if a change will pass CI gates #3045

Open
peternied opened this issue Jul 24, 2023 · 3 comments
Labels
bug Something isn't working good first issue These are recommended starting points for newcomers looking to make their first contributions. help wanted Community contributions are especially encouraged for these issues. triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.

Comments

@peternied
Copy link
Member

peternied commented Jul 24, 2023

Description

There are many checks used by the PR workflow that validate different aspects of incoming changes. There are hygiene scans, code correctness, code coverage, backward compatibility and DCO. It would be useful to have a way to run all the checks for this repository on your local machine.

What alternatives can be considered?

GitHub Action workflows execute all of the different scans and tests, these can continue to be used.

Additional Context

@peternied peternied added bug Something isn't working untriaged Require the attention of the repository maintainers and may need to be prioritized labels Jul 24, 2023
@stephen-crawford
Copy link
Contributor

[Triage] This change seems like a reasonable potential change that someone interested in infrastructure could make. Specifically, we could see additions to the precommit workflow. Labeling good first issue and help wanted.

@stephen-crawford stephen-crawford added good first issue These are recommended starting points for newcomers looking to make their first contributions. help wanted Community contributions are especially encouraged for these issues. triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Jul 24, 2023
@prabhask5
Copy link
Contributor

@peternied @scrawfor99 There appears to be another opensource tool called act, that seems to solve this problem completely, but requires an outside download and the download of docker. Is this a valid solution, or do you want something completely built into the repo?

@stephen-crawford
Copy link
Contributor

Hey @prabhask5, we are looking for something inside OpenSearch. Using act executes the github actions locally but does not work without docker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue These are recommended starting points for newcomers looking to make their first contributions. help wanted Community contributions are especially encouraged for these issues. triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.
Projects
None yet
Development

No branches or pull requests

3 participants