Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Additional investigation why OpenSAML 4.3.0 wants to use intenal OpenSearch permission #2989

Closed
willyborankin opened this issue Jul 11, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.

Comments

@willyborankin
Copy link
Collaborator

Is your feature request related to a problem?
After switching to OpenSAML version 4.3.0. We found out that 2 additional properties need to be added to the security plugin policy file (the problem was fixed here #2987).
permission java.util.PropertyPermission "*" "read,write"; - is not a big deal since it just asks for access to the internal OpenSAML classes and JDK java.lang.ref.Cleaner
while
permission org.opensearch.secure_sm.ThreadPermission "modifyArbitraryThread - is the internal OpenSearch permission and technically we can't use it. Instead permission java.lang.RuntimePermission "modifyThread"; must be used.

What solution would you like?
To move forward with OpenSAML 4.3.0 we need investigate why it uses
permission org.opensearch.secure_sm.ThreadPermission "modifyArbitraryThread.

Do you have any additional context?
Add any other context or screenshots about the feature request here.

@willyborankin willyborankin added enhancement New feature or request untriaged Require the attention of the repository maintainers and may need to be prioritized labels Jul 11, 2023
@willyborankin willyborankin changed the title [FEATURE] Additionla investigation why OpenSAML 4.3.0 wants to use intenal OpenSearch permission [FEATURE] Additional investigation why OpenSAML 4.3.0 wants to use intenal OpenSearch permission Jul 11, 2023
@peternied peternied added triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Jul 17, 2023
@peternied
Copy link
Member

[Triage] Thanks for filing, it would be good to have an understanding of the isolation/exposure model of this dependency

@willyborankin willyborankin self-assigned this Aug 22, 2023
@willyborankin
Copy link
Collaborator Author

willyborankin commented Aug 22, 2023

@cwperks seems like i found the root cause of the problem. OS tries to check permissions for InnocuousThread which appeared in JDK19. and it does not need to do it since they do not inherit any Access Control Context and therefore have no permissions. I will prepare PR for OpenSearch.

@cwperks
Copy link
Member

cwperks commented Aug 22, 2023

Nice find @willyborankin!

I'm trying to get to the root of a separate permissions issue related to the JJWT 0.10.x -> 0.11.x upgrade. This PR was required on 2.x, but not required on main and I'm unsure why.

@reta
Copy link
Collaborator

reta commented Nov 22, 2023

@willyborankin I think we could close this one, right?

@willyborankin
Copy link
Collaborator Author

@willyborankin I think we could close this one, right?

Yes

@reta reta closed this as completed Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.
Projects
None yet
Development

No branches or pull requests

4 participants