Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maintenance] Review use of SamlHTTPMetadataResolver #2932

Open
willyborankin opened this issue Jul 4, 2023 · 4 comments
Open

[Maintenance] Review use of SamlHTTPMetadataResolver #2932

willyborankin opened this issue Jul 4, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.

Comments

@willyborankin
Copy link
Collaborator

willyborankin commented Jul 4, 2023

Is your feature request related to a problem?
During review of #2927, @cwperks mentioned that the main reason of why we still use HTTP commons 4 is SamlHTTPMetadataResolver which reads IDP metadata file and track the state of it.
The new version 4.3.0 still use HTTP commons 4 though.

What solution would you like?
To exclude HTTP commons 4 completely there are 2 options exists:

  1. Implement our own solution which will use HTTP common 5. For that we need to extend org.opensaml.saml.metadata.resolver.impl.AbstractReloadingMetadataResolver and implement almost the same logic as org.opensaml.saml.metadata.resolver.impl.HTTPMetadataResolver which SamlHTTPMetadataResolver extends.
  2. Try to prepare PR in Shibboleth repository with new version (do not know what is the process since repo is not GiHub one)
@willyborankin willyborankin added enhancement New feature or request untriaged Require the attention of the repository maintainers and may need to be prioritized labels Jul 4, 2023
@willyborankin willyborankin mentioned this issue Jul 4, 2023
3 tasks
@stephen-crawford
Copy link
Contributor

[Triage] Hi @willyborankin, thank you for opening this issue. It sounds like you have done some research and that version 5 is in the works. Please follow up on what you recommend for moving forward (wait for v5 or not).

@stephen-crawford stephen-crawford added triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Jul 10, 2023
@MaciejMierzwa
Copy link
Contributor

Hi, looking into this one

@willyborankin
Copy link
Collaborator Author

willyborankin commented Dec 11, 2023

Hi, looking into this one

@MaciejMierzwa, thank you. The problem can be solved with OpenSAML 5.x but the minimum JDK version for it is JDK 17, since we still support JDK 11 it is not possible to move forward with it. Here is the issue about it: #3609

@MaciejMierzwa
Copy link
Contributor

Hi @willyborankin I created draft pr for the task: #3894
Feel free to take a look and make suggestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants