RestLayerPrivilegesEvaluator must have 100% branch code coverage

[peternied]

Coverage should be enhanced to 100% these areas

• RestLayerPrivilegesEvaluator.java 82%
• SecurityRestFilter.java 62%

[DarshitChanpura]

The tests are already added as part of #2753.

[stephen-crawford]

Closing as completed.

[peternied]

@scrawfor99 can you close this after we have verified this state?

[peternied]

Coverage should be enhanced in this areas (Adding to the description)

• RestLayerPrivilegesEvaluator.java 82%
• SecurityRestFilter.java 62%

[stephen-crawford]

Hi @peternied, of course. Sorry I thought it was completed since the associated PR was merged. My bad.

[stephen-crawford]

In RestLayerPrivilegeEvaluator, I am not going to add code coverage for:

 if (isDebugEnabled) {
            log.debug("Evaluate permissions for {} on {}", user, clusterService.localNode().getName());
            log.debug("Action: {}", actions);
            log.debug("Mapped roles: {}", mappedRoles.toString());

or

 if (isDebugEnabled) {
                    log.debug("Allowed because we have permissions for {}", actions);
                }

in SecurityRestFilter, I am not going to add coverage for:

 if (pres.isAllowed()) {
                log.debug("Request has been granted");