-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Build failure due to breaking changes introduced in core #2782
Comments
org.opensearch.core.common.Strings
[Triage] There is a fix for this pending in core. No further action is required. @RyanL1997 can you close this issue once the changes are fully merged. Thank you. |
@scrawfor99 Can you please share core issue that tracks that fix you've mentioned? I've opened another issue in core, do you think it may be related to the fix opensearch-project/OpenSearch#7714? |
Hi @martin-gaievski, sorry, I did not see your comment before. The original fix should be up in the body of the issue I believe. Let me know if that is not what you were looking for. |
[Triage] Keeping open for now for tracking purposes (and if eventually any further work is needed) |
We need to backport this to Changes in core were backported to |
Hi @parasjain1, ty for the notification~ I think we did the backport here: #2953 |
@RyanL1997 You have another item 'wip...' which I suspect was 'work in progress'. Doesn't look like there was anything else needed and the pull requests associated were merged and backported to 2.x -- assuming this is complete and closing this issue. |
What is the issue?
We need to adapt the breaking change in core OpenSearch: [Refactor] OpenSearchException and ExceptionsHelper foundation to base class OpenSearch#7508
Core OpenSearch has split the imports of
org.opensearch.common.Strings
andorg.opensearch.core.common.Strings
into two.Tracking on the original
toString()
function, since it is not defined inorg.opensearch.core.common.Strings
. The current fix is:LoggerMessageFormat.java location change causing SecurityFilter.java to not compile
Fixes
Strings
andLoggerMessageFormat
package: Fix theimport org.opensearch.core.common.Strings;
andimport org.opensearch.core.common.logging.LoggerMessageFormat;
#2781The text was updated successfully, but these errors were encountered: