Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Branch Protection] Re-enable Require 'backward-compatibility` #2235

Closed
peternied opened this issue Nov 4, 2022 · 2 comments
Closed

[Branch Protection] Re-enable Require 'backward-compatibility` #2235

peternied opened this issue Nov 4, 2022 · 2 comments
Assignees
@peternied
Labels
bug Something isn't working maintenance Project maintenance triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.

Comments

@peternied
Copy link
Member

peternied commented Nov 4, 2022 •
edited
Loading

For the main branch backward compatibility tests have been disabled while the following issues are unresolved

Once this issues have been resolved the branch protection requirements should be restored to normal
@peternied peternied added bug Something isn't working maintenance Project maintenance untriaged Require the attention of the repository maintainers and may need to be prioritized labels Nov 4, 2022
@cwperks cwperks added triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Nov 7, 2022
@cwperks
Copy link
Member

cwperks commented Nov 7, 2022

[Triage] @peternied Please close this issue once BWC Test failure has been resolved and branch protection re-applied.

Can we also remove the second item on the list as it is unrelated?

@peternied peternied self-assigned this Nov 8, 2022
@peternied peternied mentioned this issue Nov 10, 2022
Merged
1 task
@DarshitChanpura
Copy link
Member

@peternied @cwperks I've added these 4 branch protection rules to main

backward-compatibility (11, ubuntu-latest)
backward-compatibility (11, windows-latest)
backward-compatibility (17, ubuntu-latest)
backward-compatibility (17, windows-latest)

Feel free to re-open this issue if there is anything else that needs to be changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peternied peternied

Labels
bug Something isn't working maintenance Project maintenance triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@peternied @cwperks @DarshitChanpura