Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support LDAP pool pruning #2090

Closed
Martin-Kemp opened this issue Sep 15, 2022 · 1 comment
Closed

[FEATURE] Support LDAP pool pruning #2090

Martin-Kemp opened this issue Sep 15, 2022 · 1 comment
Labels
enhancement New feature or request untriaged Require the attention of the repository maintainers and may need to be prioritized

Comments

@Martin-Kemp
Copy link
Contributor

Is your feature request related to a problem?

LDAP pool pruning is a common requirement for connecting to productive ldap servers. Currently the pruning period and idle time is hard coded to 5 and 10 minutes respectively. It would be nice to be able to configure this through config.yml.

What solution would you like?

Configure ldap connection pool pruning period and idle time through config.yml. For example, currently you can enable pooling and set the min and max size. ideally pool.idle_time and pool.pruning_period should also be configurable. Like this:

pool.enabled: true
pool.min_size: 0
pool.max_size: 5
pool.idle_time: 2
pool.pruning_period: 1

What alternatives have you considered?

I'm currently running a custom image with above change.

Do you have any additional context?

Pruning period and idle time is currently set here

Maybe I'm not understanding the code correctly and this config can actually be set somewhere because there is a setting referenced:

        result.setPruneStrategy(new IdlePruneStrategy(Duration.ofMinutes(this.settings.getAsLong("pruning.period", 5l)),
                Duration.ofMinutes(this.settings.getAsLong("pruning.idleTime", 10l))));

But I have no idea where to set pruning.period and pruning.idleTime.

@Martin-Kemp Martin-Kemp added enhancement New feature or request untriaged Require the attention of the repository maintainers and may need to be prioritized labels Sep 15, 2022
@peternied
Copy link
Member

The fix for this issue has been merged, and will be released in the next 2.X distribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request untriaged Require the attention of the repository maintainers and may need to be prioritized
Projects
None yet
Development

No branches or pull requests

2 participants