Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate checking of the security plugin installation #1641

Closed
peternied opened this issue Feb 24, 2022 · 0 comments · Fixed by #1690
Closed

Automate checking of the security plugin installation #1641

peternied opened this issue Feb 24, 2022 · 0 comments · Fixed by #1690
Labels
enhancement New feature or request

Comments

@peternied
Copy link
Member

Is your feature request related to a problem? Please describe.
There was a recent pull request that was reverted because it broke the install_demo_configuration.sh script, this should have been picked up by the checks on the PR rather than being discovered after it was merged. Additional there should be manual testing requirements before merging pull requests of which this scenario was included.

Describe the solution you'd like
A new GitHub action workflow that configures opensearch, installs the security plugin from build, runs setup script(s) and makes sure the server is up and correctly configured.

Describe alternatives you've considered
Looked into how the integration tests are configured, but they don't allow triggering shell scripts.

Additional context
There is a good starting point for this effort by looking at the script used by the security dashboards plugin integration test script, see https://github.com/opensearch-project/security-dashboards-plugin/blob/main/.github/workflows/integration-test.yml

@peternied peternied added the enhancement New feature or request label Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant