Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default CI Java Version to Java 11, run tests on 8, 14 and 17 #1502

Closed
3 tasks done
Tracked by #64
dblock opened this issue Nov 17, 2021 · 5 comments · Fixed by #1580 or #1661
Closed
3 tasks done
Tracked by #64

Default CI Java Version to Java 11, run tests on 8, 14 and 17 #1502

dblock opened this issue Nov 17, 2021 · 5 comments · Fixed by #1580 or #1661
Assignees
@peternied @DarshitChanpura
Labels
maintenance Project maintenance v1.3.0

Comments

@dblock
Copy link
Member

dblock commented Nov 17, 2021 •
edited by DarshitChanpura
Loading

Coming from opensearch-project/opensearch-plugins#64, default CI Java version to 11 (LTS), and run tests on 8, 14 and 17.

  • Change the default Java version for CI in GitHub actions from 14/15 to 11 (LTS).
  • Add Java 8, 14 (used before), and 17 (next LTS) to the CI matrix.
  • Document Java versions in DEVELOPER_GUIDE.md.

Note: Java-17 is no longer a part of 1.3 release
@dblock dblock added untriaged Require the attention of the repository maintainers and may need to be prioritized v1.3.0 labels Nov 17, 2021
@dblock dblock mentioned this issue Nov 17, 2021
Closed
15 tasks
@davidlago davidlago added maintenance Project maintenance and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Jan 5, 2022
@nsri19 nsri19 mentioned this issue Jan 21, 2022
Merged
3 tasks
@davidlago davidlago linked a pull request Jan 25, 2022 that will close this issue
Modifying UTs and CI to add support for Java 8, 11 and 14 #1580
Merged
3 tasks
@dblock
Copy link
Member Author

dblock commented Feb 10, 2022

Add 17 to the matrix and you can close this.

@dblock dblock reopened this Feb 10, 2022
@davidlago
Copy link

Totally missed this one, thanks @dblock !

@DarshitChanpura DarshitChanpura mentioned this issue Feb 11, 2022
Merged
1 task
@DarshitChanpura
Copy link
Member

Java 17 has a known bug which breaks couple of tests. It is tracked separately in #1620. @dblock can we close this issue?

@peternied peternied self-assigned this Mar 4, 2022
@peternied peternied mentioned this issue Mar 4, 2022
Merged
3 tasks
@DarshitChanpura
Copy link
Member

@dblock Should we remove Java-17 from CI build matrix as we are pushing this to 2.0? or should we downgrade Gradle to 6.9 to have all tests run on Java-17 (PR: #1661)?

@DarshitChanpura
Copy link
Member

Java-17 has been removed from the 1.3 release (PR: #1668) Will close this issue after the PR is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peternied peternied

@DarshitChanpura DarshitChanpura

Labels
maintenance Project maintenance v1.3.0
Projects
None yet
Milestone
No milestone
5 participants
@dblock @peternied @davidlago @DarshitChanpura @nsri19