Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Totally disable tenancy #838

Closed
mvanderlee opened this issue Oct 15, 2021 · 20 comments · Fixed by #965
Closed

[BUG] Totally disable tenancy #838

mvanderlee opened this issue Oct 15, 2021 · 20 comments · Fixed by #965
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@mvanderlee
Copy link

Describe the bug

https://discuss.opendistrocommunity.dev/t/totally-disable-tenancy/5833

When multi-tenancy is disabled, it should not prompt the user to 'Select your tenant'
Or at least there should be an option to disable the pop-up.

To Reproduce
Steps to reproduce the behavior:

  1. Disable multi-tenancy opensearch_security.multitenancy.enabled: false
  2. Log in
  3. See popup

Expected behavior
Should not show pop-up

OpenSearch Version
1.0.0 & 1.1.0

Dashboards Version
1.0.0 & 1.1.0

Plugins

  • security
  • s3 repository

Screenshots

image

Host/Environment (please complete the following information):

  • Docker
  • Chrome

Additional context

Add any other context about the problem here.

@kavilla
Copy link
Member

kavilla commented Oct 15, 2021

Hello @mvanderlee,

Thanks for opening this! @opensearch-project/admin can you transfer this to https://github.com/opensearch-project/security-dashboards-plugin.

@peterzhuamazon peterzhuamazon transferred this issue from opensearch-project/OpenSearch-Dashboards Oct 15, 2021
@frankeros
Copy link

Hi, any updates about it?

@davidlago davidlago added the bug Something isn't working label Nov 8, 2021
@kavilla
Copy link
Member

kavilla commented Nov 9, 2021

Duplicate issue: #854

@aggarwalShivani
Copy link

Hi, any updates on when this fix will be planned?

@amirkkn
Copy link

amirkkn commented Jan 16, 2022

Hi @kavilla , is there any plan to fix this bug?

@kavilla
Copy link
Member

kavilla commented Jan 23, 2022

@kavilla
Copy link
Member

kavilla commented Jan 23, 2022

Hello @amirkkn, I see @hsiang9431-amzn assigned to it. I believe they will have better insight.

@dredwilliams
Copy link

@hsiang9431-amzn - it's been a while ... is there any progress on this?

@amirkkn
Copy link

amirkkn commented Mar 4, 2022

Hello @amirkkn, I see @hsiang9431-amzn assigned to it. I believe they will have better insight.

Hi @kavilla . I see, no one anymore was assigned to this issue. Do you see any progress about it in the near future?

@davidlago
Copy link

Hi there! it is in our radar but haven't had a chance to get to it. This seems self-contained enough to be a first issue/PR for new contributors, so tagged as such in case anyone can jump in before we get to it!

@peterzhuamazon
Copy link
Member

Is this meant to be only in main @cliu123 ?

@cliu123
Copy link
Member

cliu123 commented Apr 25, 2022

@peternied I believe that this didn't get backported to 2.0 branch just in order to minimize the risk of breaking 2.0.0-rc1 path to release. It can be a part of 2.0.0 GA if that will be safer.

@peternied
Copy link
Member

This is an issue, the PR as not been backported yet, but that is a great idea. I've added the label on the PR and we can hold the backport until the RC is avaliable.

@xonvanetta
Copy link

Would it be a hassle to backport to 1.x? As an upgrade to 2.x is a bit far away for us but we working on it

@davidlago
Copy link

@xonvanetta we no longer have new feature releases coming out for the 1.x line, only bug fixes, sorry.

@davidlago
Copy link

Sorry... it is a bug! I take it back

@jimishs
Copy link

jimishs commented Sep 8, 2022

Thanks @peternied for getting this in quickly ! This enhances the end user experience.

@peternied
Copy link
Member

Merge this fix into 1.3 - it will be available on the next patch release

#1095

@ramanavenky22
Copy link

This issue is replicable in Opensearch Version 2.7.0

@fira
Copy link

fira commented May 27, 2023

Yup. Confirming it's a thing as of 2.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.