[BUG] Dashboard login problem - global_tenant getting displayed in custom tenants if Global tenant is disabled

[deepak-rsystems]

What is the bug?
Dashboard login has a problem that if we give access to global_tenant for some user/role, then global_tenant is getting displayed in custom tenants if Global tenant is disabled.

How can one reproduce the bug?
Pre-requisites:

1. We have a custom tenant "cadm"
2. We have disabled "Global" and "Private" tenants

Steps to reproduce the behavior:

1. Go to Dashboard
2. Click on Single Sign-on
3. See that user is logged in to global_tenant by default:

4. Once the user selects the custom tenant "cadm", then the global_tenant automatically gets removed from custom tenant drop down:

What is the expected behavior?
We should not see global_tenant in custom tenants drop down if Global tenant is disabled from multi tenancy configuration.

What is your host/environment?

• OS: [e.g. iOS]
• Version [e.g. 22]
• Plugins

Do you have any screenshots?
If applicable, add screenshots to help explain your problem.

Do you have any additional context?
Opensearch version 2.4.0

[cwperks]

[Triage] @deepak-rsystems Thank you for filing this issue. We would gladly accept a PR.

@RyanL1997 can you outline the steps you took to try reproducing this issue?

[RyanL1997]

@deepak-rsystems Thanks for filing this issue, and I have reproduced this behavior and there will be a fix or further information provided soon.

[RyanL1997]

Update: I have confirmed with @cliu123 that this is a expected behavior. If the user has enabled multi-tenancy but disabled both 'Global' and 'Private' tenants, it will use this global_tenant as a temporary custom tenants before choosing/creating a custom tenants. Otherwise, it will make no difference with disabling multi-tenancy. If the user doesn't have any other custom tenant without global_tenant, it will return this error:
{"statusCode":400,"error":"Bad Request","message":"No available tenant for current user, please reach out to your system administrator"}
However, for solving this confusion, I have implemented the above fix for user who has already have their own custom tenants so that this global_tenant label won't appear in the custom tenants selection list.