Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3.2] Bump minimist to 1.2.6 #368

Merged
merged 3 commits into from
Jun 7, 2022

Conversation

joshuali925
Copy link
Member

Signed-off-by: Joshua Li [email protected]

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@joshuali925 joshuali925 requested a review from a team as a code owner June 7, 2022 17:00
davidcui1225
davidcui1225 previously approved these changes Jun 7, 2022
Copy link
Contributor

@davidcui1225 davidcui1225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - is this decrement for the service release?

@joshuali925 joshuali925 changed the title Downgrade to 1.3.2 [1.3.2] Bump minimist to 1.2.6 Jun 7, 2022
eugenesk24
eugenesk24 previously approved these changes Jun 7, 2022
Copy link
Contributor

@eugenesk24 eugenesk24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

davidcui1225
davidcui1225 previously approved these changes Jun 7, 2022
@joshuali925 joshuali925 dismissed stale reviews from davidcui1225 and eugenesk24 via fcaf596 June 7, 2022 17:57
Copy link
Contributor

@eugenesk24 eugenesk24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@joshuali925 joshuali925 merged commit 5b7c1e9 into opensearch-project:aos-1.3.2.0 Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants